Skip to content

[ENH]: Introduce maps variants of markers#460

Merged
synchon merged 15 commits intomainfrom
feat/maps-marker-variants
Sep 8, 2025
Merged

[ENH]: Introduce maps variants of markers#460
synchon merged 15 commits intomainfrom
feat/maps-marker-variants

Conversation

@synchon
Copy link
Copy Markdown
Member

@synchon synchon commented Aug 20, 2025

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduce maps variants of markers, namely:

  • MapsAggregation
  • FunctionalConnectivityMaps
  • EdgeCentricFCMaps
  • ReHoMaps
  • ALFFMaps
  • TemporalSNRMaps

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 98.49624% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.67%. Comparing base (42a09b3) to head (b7930ee).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
junifer/markers/reho/reho_maps.py 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   91.45%   91.67%   +0.22%     
==========================================
  Files         140      146       +6     
  Lines        5887     6019     +132     
  Branches      956      962       +6     
==========================================
+ Hits         5384     5518     +134     
+ Misses        325      324       -1     
+ Partials      178      177       -1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 91.67% <98.49%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/conftest.py 100.00% <100.00%> (ø)
junifer/markers/falff/falff_maps.py 100.00% <100.00%> (ø)
..._connectivity/edge_functional_connectivity_maps.py 100.00% <100.00%> (ø)
...ional_connectivity/functional_connectivity_maps.py 100.00% <100.00%> (ø)
junifer/markers/maps_aggregation.py 100.00% <100.00%> (ø)
junifer/markers/temporal_snr/temporal_snr_maps.py 100.00% <100.00%> (ø)
junifer/typing/_typing.py 100.00% <100.00%> (ø)
junifer/markers/reho/reho_maps.py 91.66% <91.66%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synchon synchon added enhancement New feature or request maps Issues or pull requests related to maps (probabilistic atlases) labels Aug 20, 2025
@synchon synchon added this to the 0.0.7 (alpha 6) milestone Aug 20, 2025
@synchon synchon self-assigned this Aug 20, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 20, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-08 12:47 UTC

@synchon synchon requested a review from fraimondo August 21, 2025 11:02
@synchon synchon force-pushed the feat/maps-marker-variants branch from 0ebb12a to b7930ee Compare September 8, 2025 10:50
@synchon synchon merged commit 130238f into main Sep 8, 2025
26 checks passed
@synchon synchon deleted the feat/maps-marker-variants branch September 8, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request maps Issues or pull requests related to maps (probabilistic atlases)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants