hscontrol/grpcv1: persist nil expiration when request omits it#3254
Open
clwluvw wants to merge 1 commit into
Open
hscontrol/grpcv1: persist nil expiration when request omits it#3254clwluvw wants to merge 1 commit into
clwluvw wants to merge 1 commit into
Conversation
CreatePreAuthKey and CreateApiKey declared `var expiration time.Time` and unconditionally passed `&expiration` to the database layer. When the gRPC request had no Expiration field, the pointer dereferenced to the zero time.Time, causing the row to be stored with expiration = 0001-01-01 00:00:00 instead of NULL. Both ValidateAPIKey and PreAuthKey.Validate then rejected the key as expired immediately. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
requested review from
juanfont,
kradalby,
nblock and
ohdearaugustin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreatePreAuthKey and CreateApiKey declared
var expiration time.Timeand unconditionally passed&expirationto the database layer. When the gRPC request had no Expiration field, the pointer dereferenced to the zero time.Time, causing the row to be stored with expiration = 0001-01-01 00:00:00 instead of NULL. Both ValidateAPIKey and PreAuthKey.Validate then rejected the key as expired immediately.Fixes: infradohq/headscale-operator#92