fix: mapping and function parameter highlighting#499
Open
davidperk wants to merge 1 commit intojuanfranblanco:masterfrom
Open
fix: mapping and function parameter highlighting#499davidperk wants to merge 1 commit intojuanfranblanco:masterfrom
davidperk wants to merge 1 commit intojuanfranblanco:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496
1. Fixes
declaration-storage-mapping(L1115)This allows nested mappings like
mapping(address => mapping(uint256 => bool))to work correctly.2. Adds
type-functionpattern (L1137-1156)New pattern to handle function type parameters like:
3. Updates
declaration-function-parameters(L952, L955, L958)Adds three
includes to recognize mapping types in parameters, function types in parameters, and visibility modifiers (external,internal, etc.).