Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d6b36c51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sed -i "/$UNINSTALL_CRON_INIT/d" /etc/storage/started_script.sh 2>/dev/null | ||
| sed -i "/$UNINSTALL_CRON_INIT/d" /jffs/.asusrouter 2>/dev/null |
There was a problem hiding this comment.
Keep uninstall startup marker non-localized
Using $UNINSTALL_CRON_INIT as the deletion pattern means uninstall depends on the active UI language, but the startup hook inserted during install is still written with a fixed Chinese marker in scripts/init.sh (#ShellCrash初始化脚本). In English mode this sed expression won’t match, so the boot script entries in /etc/storage/started_script.sh and /jffs/.asusrouter are left behind and ShellCrash can still be invoked after uninstall on those platforms.
Useful? React with 👍 / 👎.
Motivation
Description
scripts/lang/chsandscripts/lang/enfor modules includingbot_tg,check_port,ddns,providers,set_crashdir,subconverter,task_cmd, anduninstallto provide localized string variables.scripts/menus/bot_tg.sh,bot_tg_bind.sh,bot_tg_service.sh,check_port.sh,ddns.sh,providers*.sh,set_crashdir.sh,subconverter.sh,task_cmd.sh, anduninstall.sh) toload_langand replace hardcoded text with the corresponding language variables.i18n.shis sourced where required and replaced cron/job naming and logger messages with localized variables (for example the TG bot cron name and log messages).Testing
Codex Task