🐛 fix ReserveCalifornia booking URLs to use new path format#393
Open
ArtixZ wants to merge 1 commit intojuftin:mainfrom
Open
🐛 fix ReserveCalifornia booking URLs to use new path format#393ArtixZ wants to merge 1 commit intojuftin:mainfrom
ArtixZ wants to merge 1 commit intojuftin:mainfrom
Conversation
ReserveCalifornia's new site uses /park/{rec_area_id}/{facility_id}
instead of the old /Web/Default.aspx#!park/{rec_area_id}/{facility_id}
hash-fragment format. Add booking_path_hash flag to support both URL
styles across UseDirect providers.
Closes juftin#392
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/park/{rec_area_id}/{facility_id}instead of the old/Web/Default.aspx#!park/{rec_area_id}/{facility_id}hash-fragment formatbooking_path_hashclass attribute toUseDirectProviderto support both URL styles, defaulting toTrue(existing behavior) for backward compatibilitybooking_path = "park"andbooking_path_hash = FalseonReserveCaliforniato generate correct URLsBefore:
https://www.reservecalifornia.com/Web/Default.aspx#!park/695/628After:
https://www.reservecalifornia.com/park/695/628Closes #392
Test plan
Made with Cursor