ci(test): skip coverage comment on fork PRs#409
Closed
juftin wants to merge 1 commit into
Closed
Conversation
The pytest-coverage-comment action fails when run on fork PRs from first-time contributors because GITHUB_TOKEN lacks write access to post PR comments on those events. This causes a false CI failure. Only attempt to post coverage comments on PRs from the main repo (juftin/camply) and skip them for external forks.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When external contributors submit PRs from forks, the
pytest-coverage-commentaction fails withHttpError: Resource not accessible by integration.This is because GitHub overrides GITHUB_TOKEN permissions for first-time contributor fork PRs, preventing the action from posting PR comments — even though the workflow declares
pull-requests: write.The result is a false CI failure unrelated to the submitted code.
Fix
Only run the coverage comment step on PRs from the main repo (
juftin/camply), skipping external forks entirely. Coverage still generates locally — it just won't attempt post a PR comment on fork PRs.Testing
Driven by PR #407 — a legitimate fork PR blocked by this despite all 108 tests passing.