-
Notifications
You must be signed in to change notification settings - Fork 2
Major updates! #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Major updates! #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 24.85% 28.18% +3.33%
==========================================
Files 40 40
Lines 2394 2469 +75
==========================================
+ Hits 595 696 +101
+ Misses 1799 1773 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I need to update documentation as well. |
Member
Author
|
Using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major update over several parts (sorry for many changes)!
I needed to add an option for extracting image embeddings without patching, so I decided while adding this feature, make a major refactoring as well.
no_patchingoption (only works for images with height == width)FFImageDatasetIterableDatasetthat yields images / patches in batch.pims(except for numpy array image, which already loaded).Nowzarris being used as the feature storage file (old storages are not compatible anymore, sorry).Mainly because of appending features ofzarrarray, and more control over compression.run_pipeline.pycan be used for large stack prediction onhpcwithout having a temporary feature store (faster). Also, it has an option for only extracting features into azarrstorage now.overlapis nowpatch_size // 4as opposed topatch_size // 2before. This will speed up extraction and prediction (I need to check the result stats with this change).