Support servers in path macro#1293
Open
infiniteregrets wants to merge 3 commits intojuhaku:masterfrom
Open
Conversation
infiniteregrets
commented
Jan 16, 2025
Comment on lines
+35
to
+36
| server.url = parse_utils::parse_next_literal_str_or_expr(&server_stream)? | ||
| } |
Author
There was a problem hiding this comment.
rest of the impl is copied, I think URLs can be common amongst paths, so changing it to LitStrOrExpr just like how tags work!
juhaku
approved these changes
May 26, 2025
Owner
juhaku
left a comment
juhaku
left a comment
There was a problem hiding this comment.
Great work, only missing CHANGELOG entry, but I can also add that, and this is good to go. 👍
Author
|
@juhaku any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Just want to say thanks for developing this amazing library. I realized that this piece was missing as per these docs https://swagger.io/docs/specification/v3_0/api-host-and-base-path/ and is my use case to be able to override the servers.
I see it is available in the corresponding trait but not the macro, so adding it here.
Very much a WIP, will test and add a few more commits later