Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Gateway API HTTPRoute support to the JuiceFS CSI Driver Helm chart, providing an alternative to Ingress for exposing the dashboard web service using Kubernetes Gateway API L7 routing capabilities.
Changes:
- Added HTTPRoute template with support for hostname reuse from ingress configuration and custom routing rules
- Added httpRoute configuration section to values.yaml with options for parentRefs, hostnames, and extraPaths
- Bumped chart version from 0.31.1 to 0.31.2
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| charts/juicefs-csi-driver/Chart.yaml | Version bump to 0.31.2 for new HTTPRoute feature |
| charts/juicefs-csi-driver/values.yaml | Added httpRoute configuration section with enabled flag, parentRefs, hostnames, and extraPaths options |
| charts/juicefs-csi-driver/templates/httproute.yaml | New template generating Gateway API HTTPRoute resource for dashboard service |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LeoQuote
force-pushed
the
feat_httproute_support
branch
from
97408d9 to
de66b94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zxh326
reviewed
Mar 2, 2026
zxh326
reviewed
Mar 2, 2026
Comment on lines
+379
to
+381
| # When true, reuse host and path settings from the ingress section above to build the HTTPRoute. | ||
| # When false, configure hostnames and extraPaths explicitly below. | ||
| reuseIngressConfiguration: false |
Member
There was a problem hiding this comment.
It seems that this logic isn’t necessary. This would make the httproute template simpler and more maintainable.
Co-authored-by: Zzde <zhangxh1997@gmail.com>
zxh326
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway API is an official Kubernetes project focused on L4 and L7 routing in Kubernetes.
This pr support generating httproute resource to expose dashboard web service.