KeyError: 'PROGRAMFILES(X86)' on Windows XP in 1.7.8

[MarkCallow]

$ ./emsdk.bat install latest-32bit
Installing 'sdk-1.7.8-32bit'..
Installing 'clang-3.2-32bit'..
On Windows XP during ./emsdk install latest-32bit, either during or after the node installation, I get the following error. I was getting this in the previous SDK version as well after receiving the change to look in both PROGRAMFILES and PROGRAMFIILES(X86). I manually hacked emsdk to avoid it.

The contents of file 'clang_3.2_32bit.zip' already exist in destination 'C:/Program Files/Emscripten/clang/3.2_32bit', skipping.
Done.
Done.
Installing 'node-0.10.17-32bit'..
Traceback (most recent call last):
File "C:\Program Files\Emscripten\emsdk", line 925, in
sys.exit(main())
File "C:\Program Files\Emscripten\emsdk", line 910, in main
tool.install()
File "C:\Program Files\Emscripten\emsdk", line 555, in install
success = tool.install()
File "C:\Program Files\Emscripten\emsdk", line 568, in install
dst_file = download_file(urlparse.urljoin(emsdk_packages_url, self.download_url()), self.installation_path())
File "C:\Program Files\Emscripten\emsdk", line 427, in installation_path
pth = self.windows_install_path.replace("%MSBuildPlatformsDir%", find_msbuild_dir())
File "C:\Program Files\Emscripten\emsdk", line 394, in find_msbuild_dir
program_files_x86 = os.environ['ProgramFiles(x86)']
File "C:\Program Files\Emscripten\python\2.7.5.1_32bit\lib\os.py", line 423, in getitem
return self.data[key.upper()]
KeyError: 'PROGRAMFILES(X86)'

[MarkCallow]

I made the following temporary hack to workaround the problem:

  -program_files_x86 = os.environ['ProgramFiles(x86)']
  -if not program_files_x86:
  -  program_files_x86 = 'C:/Program Files (x86)'
  ----
  +program_files_x86 = 'C:/Program Files (x86)'

[juj]

Thanks! I believe the above commit should fix it, however I don't have a Windows XP setup to test. Let me know if an issue still exists with the above code.

[MarkCallow]

This code works. When do you expect to update the sdk again?

[ocraml]

the issue seems related to the sh.exe used. I don't know the exact root cause, but running python from the GNU Eclipse build tool shell gave me the KeyError: 'PROGRAMFILES(X86)' error because os.environ['ProgramFiles(x86)'] did not find that path.
Running the same python script with in the sh.exe I have in the git/bin worked fine.