Skip to content

Conversation

@johnsca
Copy link
Contributor

@johnsca johnsca commented Mar 8, 2018

Fixes #216

@johnsca
Copy link
Contributor Author

johnsca commented Mar 8, 2018

To test:

juju bootstrap localhost
juju change-user-password
tox -e example -- examples/connect_current_model.py

I'd like to include this in the integration tests, but it would affect every single test, so I don't think it's a good idea.

@johnsca johnsca force-pushed the bug/216-auth-tag branch 5 times, most recently from 62a1001 to 686507c Compare March 8, 2018 23:44
Copy link
Contributor

@tvansteenburgh tvansteenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't a separate controller be bootstrapped for this test?

Also what's your interpretation of the test failure. Is that a due to a change in edge juju?

docs/readme.rst Outdated


More examples can be found in the docs, as well as in the ``examples/``
directory of the source tree which can be run with using ``tox``. For
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/with//

@johnsca
Copy link
Contributor Author

johnsca commented Mar 9, 2018

The tests don't do the controller bootstrapping, and depend on one already being bootstrapped, so I'm not sure how we could mark one test to be run differently. I guess a separate tox env?

The same test passed with Juju edge on on the push run. This is one of the inconsistent failures we sometimes see on Travis (others being test_scp failing / timing out, package installation failing, bootstrap failing, and store timeouts). The error is from LXD, and it seems as if the ZFS kernel module isn't enabled sometimes on Travis; I'm not sure if we could do something to ensure that it is, but it makes me wonder if there are different images that we end up running under on Travis sometimes. Restarting the job will probably make it pass.

@johnsca johnsca force-pushed the bug/216-auth-tag branch from 686507c to 8737faa Compare March 9, 2018 15:16
@johnsca
Copy link
Contributor Author

johnsca commented Mar 9, 2018

It looks like adding the password: line back to accounts.yaml is enough to get it back to working, but it would still affect other tests that are being run in parallel. Is there any way to indicate that a given test must be run on its own?

johnsca added 3 commits May 15, 2018 12:10
Adds a separate testenv for tests that can't be run in parallel with
other tests.  The macaroon auth test is the first, because it modifies
the login type of the default user and thus could break other tests
logging in in the middle of it.
@johnsca johnsca force-pushed the bug/216-auth-tag branch from 8737faa to 0cb0903 Compare May 16, 2018 19:11
johnsca added 3 commits May 17, 2018 16:18
Both Juju stable and edge will automatically create the network bridge
if it doesn't exist during bootstrap, but it seems that there's an issue
in edge such that Juju doesn't wait properly for the addresses to become
available.  Thus, edge fails to bootstrap while stable doesn't.  By
manually creating the network bridge and waiting for the addresses
ourselves, we should avoid that.
@johnsca johnsca merged commit 2d94186 into master May 17, 2018
@johnsca johnsca deleted the bug/216-auth-tag branch April 1, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants