-
Notifications
You must be signed in to change notification settings - Fork 103
Always send auth-tag even with macaroon auth #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To test: I'd like to include this in the integration tests, but it would affect every single test, so I don't think it's a good idea. |
62a1001 to
686507c
Compare
tvansteenburgh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't a separate controller be bootstrapped for this test?
Also what's your interpretation of the test failure. Is that a due to a change in edge juju?
docs/readme.rst
Outdated
|
|
||
|
|
||
| More examples can be found in the docs, as well as in the ``examples/`` | ||
| directory of the source tree which can be run with using ``tox``. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/with//
|
The tests don't do the controller bootstrapping, and depend on one already being bootstrapped, so I'm not sure how we could mark one test to be run differently. I guess a separate tox env? The same test passed with Juju edge on on the push run. This is one of the inconsistent failures we sometimes see on Travis (others being |
686507c to
8737faa
Compare
|
It looks like adding the |
Adds a separate testenv for tests that can't be run in parallel with other tests. The macaroon auth test is the first, because it modifies the login type of the default user and thus could break other tests logging in in the middle of it.
Both Juju stable and edge will automatically create the network bridge if it doesn't exist during bootstrap, but it seems that there's an issue in edge such that Juju doesn't wait properly for the addresses to become available. Thus, edge fails to bootstrap while stable doesn't. By manually creating the network bridge and waiting for the addresses ourselves, we should avoid that.
Fixes #216