Release 2.8.0#412
Conversation
hpidcock
commented
May 13, 2020
hpidcock
commented
- Update facade methods for Juju 2.8.0
- Fixes codegen for Python 3.7+
- Nested facade definitions are now deserialised properly (e.g. storage on ApplicationDeploy)
wallyworld
left a comment
wallyworld
left a comment
There was a problem hiding this comment.
Good catch on the nested args.
I assume there's been a manual test done using this to drive a 2.8 controller. If not, can it be done prior to landing?
howbazaar
left a comment
howbazaar
left a comment
There was a problem hiding this comment.
Just one question, non-blocking.
| application : str | ||
| branch : str | ||
| Returns -> typing.Union[str, typing.Mapping[str, typing.Any], _ForwardRef('Value')] | ||
| Returns -> typing.Union[str, typing.Mapping[str, typing.Any], ForwardRef('Value')] |
There was a problem hiding this comment.
Do you know why these changed?
There was a problem hiding this comment.
They were internal types pre 3.7
Yep tested some examples against both a k8s and lxd controller on 2.8 |
|
!!build!! |
- Update facade methods for Juju 2.8.0 - Fixes codegen for Python 3.7+ - Nested facade definitions are now deserialised properly (e.g. storage on ApplicationDeploy)
hpidcock
force-pushed
the
fix-missing-facade
branch
from
6f4a6f4 to
4d2895a
Compare
|
|
1 similar comment
|
|
|
Hi all - this patch and the 2.8.0 libjuju release regressed usage in all of the OpenStack Charm gates: |
5 participants
