Skip to content

Fixes multiple issues#416

Merged
jujubot merged 2 commits intojuju:masterfrom
hpidcock:fix-2.8
May 14, 2020
Merged

Fixes multiple issues#416
jujubot merged 2 commits intojuju:masterfrom
hpidcock:fix-2.8

Conversation

@hpidcock
Copy link
Copy Markdown
Member

@hpidcock hpidcock commented May 14, 2020 •
edited
Loading

  • Fix tox.ini to use supported python versions.
  • Fix contraints regex using subscript on matches (py36).
  • Fix facade return type documentation.
  • Fix schema objects with array values.
  • Fix subscript lookups by using JSON keys.
  • Add definition test.

Addresses #413 #414

wallyworld
wallyworld approved these changes May 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see any obvious issues, but should be tested in real use before landing.
What QA was done against a real controller?

@hpidcock
Copy link
Copy Markdown
Member Author

hpidcock commented May 14, 2020

!!build!!

@hpidcock
Copy link
Copy Markdown
Member Author

hpidcock commented May 14, 2020

Can't see any obvious issues, but should be tested in real use before landing.
What QA was done against a real controller?

Still testing at the moment. Using a more complex model on k8s and lxd.

@hpidcock
Fixes multiple issues
862d336 
- Fix tox.ini to use supported python versions.
- Fix contraints regex using subscript on matches (py36).
- Fix facade return type documentation.
- Fix schema objects with array values.
- Add definition test.
@hpidcock
Copy link
Copy Markdown
Member Author

hpidcock commented May 14, 2020

!!build!!

@hpidcock
Copy link
Copy Markdown
Member Author

hpidcock commented May 14, 2020 •
edited
Loading

With juju 2.8-rc2

  • Tested examples/get_cloud against lxd
  • Tested examples/fullstatus against lxd with openstack bundle.
  • Tested examples/get_cloud against k8s
  • Tested examples/fullstatus against k8s with osm bundle
  • Tested examples/deploy against lxd

@hpidcock
Copy link
Copy Markdown
Member Author

hpidcock commented May 14, 2020

$$merge$$

@jujubot jujubot merged commit 9e1409a into juju:master May 14, 2020
@hpidcock hpidcock linked an issue May 14, 2020 that may be closed by this pull request
*** TypeError: 'ActionSpec' object is not subscriptable #417
Closed
This was referenced May 14, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallyworld wallyworld wallyworld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

*** TypeError: 'ActionSpec' object is not subscriptable

3 participants

@hpidcock @wallyworld @jujubot