Fix bug #436#437
Merged
jujubot merged 1 commit intojuju:masterfrom Aug 25, 2020
davigar15:fix-bug-436-consume-without-juju-resources-locally
Merged
Fix bug #436#437jujubot merged 1 commit intojuju:masterfrom davigar15:fix-bug-436-consume-without-juju-resources-locally
jujubot merged 1 commit intojuju:masterfrom
davigar15:fix-bug-436-consume-without-juju-resources-locally
Conversation
Contributor
|
Can one of the admins verify this patch? |
9 similar comments
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Member
|
!!build!! |
Member
|
@davigar15 can you fix these from the linter: |
…ion about juju controllers
Member
|
!!build!! |
3 similar comments
Member
|
!!build!! |
Member
|
!!build!! |
Member
|
!!build!! |
Member
|
|
SimonRichardson
approved these changes
Aug 25, 2020
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
juju.model.Model.consume() works without local information about juju controllers.
New argument
controller: In case that object if specified, the consume function will use that as the controller object to get some needed information.