Skip to content

CharmHub - Find#462

Merged
jujubot merged 1 commit intojuju:2.9from
SimonRichardson:charm-hub-find
Jan 8, 2021
Merged

CharmHub - Find#462
jujubot merged 1 commit intojuju:2.9from
SimonRichardson:charm-hub-find

Conversation

@SimonRichardson
Copy link
Copy Markdown
Member

This requires #460 to land first.

The following adds the ability to query the charmhub repository. It uses
the controller to query the charmhub repository so is really easy for
clients to also use the same logic/code path as the go CLI.

@SimonRichardson SimonRichardson changed the title Find query using charmhub CharmHub - Find Jan 6, 2021
@SimonRichardson SimonRichardson mentioned this pull request Jan 6, 2021
Copy link
Copy Markdown
Contributor

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Contributor

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The following adds the ability to query the charmhub repository. It uses
the controller to query the charmhub repository so is really easy for
clients to also use the same logic/code path as the go CLI.
@SimonRichardson
Copy link
Copy Markdown
Member Author

$$merge$$

@SimonRichardson
Copy link
Copy Markdown
Member Author

!!build!!

@SimonRichardson
Copy link
Copy Markdown
Member Author

$$merge$$

@jujubot jujubot merged commit d6d157f into juju:2.9 Jan 8, 2021
@SimonRichardson SimonRichardson deleted the charm-hub-find branch January 8, 2021 16:01
jujubot added a commit that referenced this pull request Jan 8, 2021
#463

Requires #460 and #462 to land first

The following starts to implement charm origin. These are required for
the deploy commands where we're talking about origin, channels and
platforms. If we make types of these then we can pass them around
knowing exactly the correct types at hand.

The code is pretty much a copy and pasted from juju itself with some
modifications to channels that don't take into account branches.
@SimonRichardson SimonRichardson mentioned this pull request May 20, 2021
jujubot added a commit that referenced this pull request May 26, 2021
#494

The following merges 2.9 into master.

eed19e4 (upstream/2.9, origin/2.9, 2.9) Merge pull request #492 from tlm/kube-proxy-support-2
ab33f33 Merge pull request #493 from SimonRichardson/remove-machine-workaround
5c2dfa9 Merge pull request #491 from tlm/2.9.1-facades
b24e750 Merge pull request #490 from tlm/kube-proxy-support-2
aaa651c Merge pull request #482 from SimonRichardson/find-parameters
bde724b Merge pull request #481 from SimonRichardson/merge-master-2.9
fa1b85f Merge pull request #464 from SimonRichardson/charm-hub-url
195191b Merge pull request #463 from SimonRichardson/charm-hub-origin
d6d157f Merge pull request #462 from SimonRichardson/charm-hub-find
6fab2ee Merge pull request #460 from SimonRichardson/charm-hub-info
5e61dd2 Merge pull request #459 from SimonRichardson/rename-upgrade-charm-refresh
73604c8 Merge pull request #456 from SimonRichardson/update-schema-2.9-rc3
6c0437a Merge pull request #457 from SimonRichardson/ensure-charm-store-prefix
eb849e4 Merge pull request #455 from SimonRichardson/2.9
1a77394 Merge pull request #449 from achilleasa/support-new-expose-params-for-applications
ad3c449 Merge pull request #448 from achilleasa/gen-2.9-beta-client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants