Skip to content

Bundle: Exposed endpoints missing #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jujubot merged 1 commit into from
Jun 2, 2021
Merged

Bundle: Exposed endpoints missing #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions juju/bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,7 @@ class ExposeChange(ChangeInfo):
def __init__(self, change_id, requires, params=None):
super(ExposeChange, self).__init__(change_id, requires)

self.exposed_endpoints = None
if isinstance(params, list):
self.application = params[0]
elif isinstance(params, dict):
Expand Down
3 changes: 2 additions & 1 deletion tests/unit/test_bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,8 @@ def test_list_params(self):
change = ExposeChange(1, [], params=["application"])
self.assertEqual({"change_id": 1,
"requires": [],
"application": "application"}, change.__dict__)
"application": "application",
"exposed_endpoints": None}, change.__dict__)

def test_dict_params(self):
change = ExposeChange(1, [], params={"application": "application"})
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ deps =
pytest-xdist
Twine
websockets
kubernetes
# use fork to pick up fix for https://github.com/aaugustin/websockets/pull/528
git+https://github.com/johnsca/websockets@bug/client-redirects#egg=websockets ; python_version<'3.9'

Expand Down