fix: Prevent SQL injection in metadata filter queries#1274
Merged
Conversation
- Changed AlgoliaSearchArguments.attributes_to_retrieve type from dict to list[str] in TypeSpec - Updated Algolia integration to use attributesToRetrieve parameter correctly - Added comment to explain workflow module usage in task_execution/helpers.py - Fixed SQL injection vulnerability in bulk_delete_docs.py with proper parameterization - Enhanced CLAUDE.md with instructions for working with nested CLAUDE.md files - Added note about modifying TypeSpec files instead of autogen files
…──────────────────────�[0m
�[38;5;238m│ �[0m�[1mSTDIN�[0m
�[38;5;238m───────┼────────────────────────────────────────────────────────────────────────�[0m
�[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;131;148;150mfix: Prevent SQL injection in metadata filter queries�[0m
�[38;5;238m 2�[0m �[38;5;238m│�[0m
�[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;131;148;150mThis commit addresses issue #1266 by:�[0m
�[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;131;148;150m1. Creating a new `build_metadata_filter_conditions` utility function that safely builds SQL conditions from metadata filters �[0m
�[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;131;148;150m2. Refactoring queries that use metadata filtering to use this utility function�[0m
�[38;5;238m 6�[0m �[38;5;238m│�[0m �[38;2;131;148;150m3. Ensuring proper parameterization for all SQL queries to prevent injection attacks�[0m
�[38;5;238m 7�[0m �[38;5;238m│�[0m
�[38;5;238m 8�[0m �[38;5;238m│�[0m �[38;2;131;148;150m🤖 Generated with [Claude Code](https://claude.ai/code)�[0m
�[38;5;238m 9�[0m �[38;5;238m│�[0m
�[38;5;238m 10�[0m �[38;5;238m│�[0m �[38;2;131;148;150mCo-Authored-By: Claude <noreply@anthropic.com>�[0m
�[38;5;238m───────┴────────────────────────────────────────────────────────────────────────�[0m
Contributor
PR Reviewer Guide 🔍(Review updated until commit 522ac81)Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨Latest suggestions up to 522ac81
Previous suggestionsSuggestions up to commit c52217f
|
||||||||||||||||||||
Contributor
|
LGTM 👍 |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c52217f in 1 minute and 26 seconds
More details
- Looked at
434lines of code in13files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:1452
- Draft comment:
The metadata_filter parameter is defined as an object with additionalProperties. Verify that the backend properly sanitizes these inputs so that the OpenAPI definition remains consistent with the SQL injection prevention measures. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:7070
- Draft comment:
The definition for Tools.AlgoliaSearchArguments now declares 'attributes_to_retrieve' as an array of strings instead of an object. This change appears correct given the new typespec model—ensure that all client integrations and documentation are updated accordingly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:1452
- Draft comment:
The metadata_filter parameter is defined as an object with additionalProperties. Confirm that backend validation (and any related query building) safely handles this field to prevent SQL injection vulnerabilities. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. agents-api/agents_api/autogen/Tools.py:258
- Draft comment:
Typo in the docstring for 'download_pdf': the phrase 'The download the pdf of the results' is awkward and unclear. Consider rephrasing it to something like 'Whether to download the PDF of the results' or 'Download the PDF of the results' (with proper capitalization of 'PDF'). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. agents-api/agents_api/queries/utils.py:83
- Draft comment:
The definition of pg_query uses an unusual syntax "def pg_query**P", which seems like a typographical error. It might be intended to use generic type parameters without the extra asterisks (possibly 'def pg_queryP' or another correct syntax). Please double-check this syntax. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. agents-api/agents_api/workflows/task_execution/helpers.py:131
- Draft comment:
Typo found: 'seprated_workflow_name' should be corrected to 'separated_workflow_name' for clarity and consistency. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. integrations-service/integrations/autogen/Tools.py:258
- Draft comment:
Typo in the docstring for the 'download_pdf' field in ArxivSearchArguments. It currently says "The download the pdf of the results". Consider rephrasing it to something like "Download the PDF of the results" for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_kxAlq8kifxNcwRlj
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…──────────────────────�[0m
�[38;5;238m│ �[0m�[1mSTDIN�[0m
�[38;5;238m───────┼────────────────────────────────────────────────────────────────────────�[0m
�[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;131;148;150mfix: Add table_alias parameter to prevent ambiguous column references�[0m
�[38;5;238m 2�[0m �[38;5;238m│�[0m
�[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;131;148;150mThis commit enhances the SQL injection prevention fixes from the previous commit by:�[0m
�[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;131;148;150m1. Adding an optional table_alias parameter to the build_metadata_filter_conditions utility function�[0m
�[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;131;148;150m2. Updating metadata filtering code to use table aliases for columns to prevent ambiguous column references�[0m
�[38;5;238m 6�[0m �[38;5;238m│�[0m �[38;2;131;148;150m3. Specifically fixing the "column reference 'metadata' is ambiguous" error�[0m
�[38;5;238m 7�[0m �[38;5;238m│�[0m
�[38;5;238m 8�[0m �[38;5;238m│�[0m �[38;2;131;148;150m🤖 Generated with [Claude Code](https://claude.ai/code)�[0m
�[38;5;238m 9�[0m �[38;5;238m│�[0m
�[38;5;238m 10�[0m �[38;5;238m│�[0m �[38;2;131;148;150mCo-Authored-By: Claude <noreply@anthropic.com>�[0m
�[38;5;238m───────┴────────────────────────────────────────────────────────────────────────�[0m
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 5906da7 in 44 seconds
More details
- Looked at
66lines of code in3files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. agents-api/agents_api/queries/docs/bulk_delete_docs.py:50
- Draft comment:
Good use of the utility with a table alias to ensure the metadata column is correctly referenced. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. agents-api/agents_api/queries/docs/list_docs.py:107
- Draft comment:
Properly updated call to build_metadata_filter_conditions with table alias 'd.'; ensures the WHERE clause references the correct table. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. agents-api/agents_api/queries/utils.py:343
- Draft comment:
The updated build_metadata_filter_conditions correctly accepts a table_alias parameter to prefix the metadata column. Ensure that any provided alias is safe (here it is hardcoded as 'd.' in calling functions). - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. agents-api/agents_api/queries/docs/bulk_delete_docs.py:50
- Draft comment:
Good use of the table_alias parameter ('d.') with build_metadata_filter_conditions to ensure the metadata column is correctly qualified. This helps mitigate SQL injection risks. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. agents-api/agents_api/queries/docs/list_docs.py:107
- Draft comment:
Consistently applying table_alias ('d.') in the metadata filter call is appropriate. Note that sort_by and direction are validated elsewhere, keeping the query safe from injection. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. agents-api/agents_api/queries/utils.py:343
- Draft comment:
The update to build_metadata_filter_conditions to accept a table_alias parameter improves flexibility and security. As an enhancement, consider grouping multiple metadata conditions in parentheses to clearly define precedence in complex queries. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
Workflow ID: wflow_8ed8koSXF8tO3qeO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
qodo-free-for-open-source-projects
bot
added
Review effort 3/5
and removed
Review effort 2/5
labels
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 522ac81 in 1 minute and 26 seconds
More details
- Looked at
438lines of code in13files - Skipped
0files when reviewing. - Skipped posting
14drafted comments based on config settings.
1. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:7071
- Draft comment:
The change for AlgoliaSearchArguments now uses an array for attributes_to_retrieve instead of an object. This aligns with the intended model update. Please confirm that all associated endpoints and schema references (both for creation and updates) have been updated consistently. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:3024
- Draft comment:
BulkDeleteDocsRequest schema now clearly requires both metadata_filter and delete_all. Verify that the frontend and backend correctly interpret an empty metadata_filter (i.e. empty object) when delete_all is not set, to avoid unintentional deletions. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:1440
- Draft comment:
Ensure that any updated parameter definitions for metadata_filter in common pagination options are reflected in all endpoints (e.g. /agents/{id}/docs, /users/{id}/docs, etc.) to fully protect against SQL injection, by enforcing proper type as defined here. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:7077
- Draft comment:
AlgoliaSearchArguments now defines 'attributes_to_retrieve' as an array of strings, improving type safety. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:3025
- Draft comment:
BulkDeleteDocsRequest schema now requires both 'metadata_filter' and 'delete_all', ensuring consistent handling of metadata filtering. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. typespec/tsp-output/@typespec/openapi3/openapi-1.0.0.yaml:1452
- Draft comment:
The common parameter 'metadata_filter' is defined as an object with additionalProperties and a default empty object, aligning with the safe query filtering approach. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
7. CLAUDE.md:16
- Draft comment:
Typo: Consider changing 'fastAPI' to 'FastAPI' for consistency with the proper naming convention. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. CLAUDE.md:79
- Draft comment:
Typo: In the testing expression line, consider removing the space in '$ your_expr_here' to read '$your_expr_here'. This will make the example clearer. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
9. agents-api/agents_api/autogen/Tools.py:1344
- Draft comment:
Typo: In the FunctionDef class docstrings, "overriden" should be corrected to "overridden" for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. agents-api/agents_api/autogen/Tools.py:258
- Draft comment:
Typo in the ArxivSearchArguments (and ArxivSearchArgumentsUpdate) docstring: "The download the pdf of the results" is awkwardly phrased. Consider rephrasing to something like "Whether to download the PDF of the results". - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
11. agents-api/agents_api/workflows/task_execution/helpers.py:131
- Draft comment:
Typographical Error: The variable 'seprated_workflow_name' is misspelled. Consider renaming it to 'separated_workflow_name' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
12. integrations-service/integrations/autogen/Tools.py:258
- Draft comment:
The docstring for 'download_pdf' currently reads 'The download the pdf of the results'. Consider revising it to something like 'Flag indicating whether to download the PDF of the results' to improve clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. integrations-service/integrations/autogen/Tools.py:1344
- Draft comment:
There is a typographical error in the comment for FunctionDef: 'overriden' should be corrected to 'overridden' for proper spelling. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
14. schemas/create_task_request.json:3120
- Draft comment:
There's a typographical error in the schema: 'CompetionUsage' appears to be a misspelling. It should be 'CompletionUsage'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_v17F8DJWSc0nKC69
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
Author
|
@Vedantsahai18 @Ahmad-mtos - should the qodo comment be fixed?
integrations-service/integrations/utils/integrations/algolia.py [30-38] -search_request = {
- "requests": [
- {
- "indexName": arguments.index_name,
- "query": arguments.query,
- "hitsPerPage": arguments.hits_per_page,
- "attributesToRetrieve": arguments.attributes_to_retrieve or [],
- }
- ]
+search_params = {
+ "indexName": arguments.index_name,
+ "query": arguments.query,
+ "hitsPerPage": arguments.hits_per_page,
}
+if arguments.attributes_to_retrieve is not None:
+ search_params["attributesToRetrieve"] = arguments.attributes_to_retrieve
+
+search_request = {
+ "requests": [search_params]
+}
+ |
Contributor
|
@creatorrr the qodo comment is relevant. We should return |
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ba55e80 in 22 seconds
More details
- Looked at
33lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. integrations-service/integrations/utils/integrations/algolia.py:36
- Draft comment:
Good refactor: splitting search_params and adding attributesToRetrieve conditionally improves clarity. No issues observed here. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. integrations-service/integrations/utils/integrations/algolia.py:30
- Draft comment:
Good refactoring: Separating the search parameters and conditionally adding 'attributesToRetrieve' improves clarity. This explicit check avoids unintended defaults when an empty list is passed. Note that this change doesn’t affect SQL injection prevention but aligns with safe practices elsewhere. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_Wu2wdImt3r9OET4Z
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
…──────────────────────�[0m
�[38;5;238m│ �[0m�[1mSTDIN�[0m
�[38;5;238m───────┼────────────────────────────────────────────────────────────────────────�[0m
�[38;5;238m 1�[0m �[38;5;238m│�[0m �[38;2;131;148;150mtest: Add tests for SQL injection prevention in metadata filters�[0m
�[38;5;238m 2�[0m �[38;5;238m│�[0m
�[38;5;238m 3�[0m �[38;5;238m│�[0m �[38;2;131;148;150mThis commit adds test coverage for the SQL injection prevention fixes:�[0m
�[38;5;238m 4�[0m �[38;5;238m│�[0m �[38;2;131;148;150m1. Tests for the new build_metadata_filter_conditions utility function�[0m
�[38;5;238m 5�[0m �[38;5;238m│�[0m �[38;2;131;148;150m2. Tests for preventing SQL injection in list_docs and bulk_delete_docs�[0m
�[38;5;238m 6�[0m �[38;5;238m│�[0m �[38;2;131;148;150m3. Tests for preventing SQL injection in list_agents�[0m
�[38;5;238m 7�[0m �[38;5;238m│�[0m
�[38;5;238m 8�[0m �[38;5;238m│�[0m �[38;2;131;148;150mThe tests ensure that metadata filters containing special characters or SQL injection patterns�[0m
�[38;5;238m 9�[0m �[38;5;238m│�[0m �[38;2;131;148;150mare properly escaped and parameterized, preventing SQL injection attacks.�[0m
�[38;5;238m 10�[0m �[38;5;238m│�[0m
�[38;5;238m 11�[0m �[38;5;238m│�[0m �[38;2;131;148;150m🤖 Generated with [Claude Code](https://claude.ai/code)�[0m
�[38;5;238m 12�[0m �[38;5;238m│�[0m
�[38;5;238m 13�[0m �[38;5;238m│�[0m �[38;2;131;148;150mCo-Authored-By: Claude <noreply@anthropic.com>�[0m
�[38;5;238m───────┴────────────────────────────────────────────────────────────────────────�[0m
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c94f5be in 1 minute and 31 seconds
More details
- Looked at
475lines of code in3files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. agents-api/tests/test_agent_metadata_filtering.py:107
- Draft comment:
Ensure SQL injections are properly handled even when metadata keys include quotes or dashes. The tests appear comprehensive. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. agents-api/tests/test_docs_metadata_filtering.py:60
- Draft comment:
Test injection filters for docs queries look adequate; verifying no unexpected deletions. Good job! - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. agents-api/tests/test_metadata_filter_utils.py:37
- Draft comment:
Be cautious of relying on dictionary key order for multiple filters. Consider sorting keys in tests or in build_metadata_filter_conditions for deterministic order. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
Python 3.7+ dictionaries maintain insertion order, but the test is relying on specific parameter ordering which could make it brittle. However, this is a test file, not production code. The test's purpose is to verify SQL injection prevention, not ordering. The exact string matching is perhaps overly strict but that's a different issue.
The comment identifies a real issue with test brittleness, but is it important enough to fix? The test will still catch SQL injection issues regardless of parameter order.
While technically correct, this is a minor test implementation detail that doesn't affect the core functionality being tested. The test's primary purpose of verifying SQL injection prevention is achieved either way.
The comment should be deleted as it suggests a change that, while technically valid, is not important enough to warrant modifying the tests. The tests still effectively verify the core security functionality.
4. agents-api/tests/test_agent_metadata_filtering.py:108
- Draft comment:
Injection filter tests cover common SQL injection patterns effectively. The test verifies that malicious keys/values return no results. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. agents-api/tests/test_docs_metadata_filtering.py:60
- Draft comment:
SQL injection tests for both list_docs and bulk_delete_docs are well-structured to ensure that unexpected matches or deletions do not occur. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. agents-api/tests/test_metadata_filter_utils.py:72
- Draft comment:
The utility tests for build_metadata_filter_conditions properly validate that SQL injection inputs are parameterized. Note that the test for multiple filters assumes a consistent dictionary order, which is safe in Python 3.7+ but might need attention if running on older versions. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
Workflow ID: wflow_jDV0CwNjuXmN0tuO
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f4d252f in 1 minute and 3 seconds
More details
- Looked at
56lines of code in2files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. schemas/create_agent_request.json:196
- Draft comment:
Changed 'attributes_to_retrieve' type from object to an array of strings. Confirm that existing consumers are updated accordingly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. schemas/create_task_request.json:196
- Draft comment:
Modified 'attributes_to_retrieve' schema to be an array of strings instead of an object. Verify that this schema change aligns with the application's expectations. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. schemas/create_agent_request.json:196
- Draft comment:
The change from type 'object' to an array with string items for 'attributes_to_retrieve' is clear and aligns with the intended model update. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. schemas/create_task_request.json:196
- Draft comment:
The update enforcing 'attributes_to_retrieve' as an array of strings (instead of an object) is consistent with the new AlgoliaSearchArguments model. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. schemas/create_task_request.json:1190
- Draft comment:
In the JSON schema definition for 'BrowserbaseContextArguments', the title is 'Projectid'. Consider changing this to 'Project ID' for improved readability and consistency with common naming conventions. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. schemas/create_task_request.json:1440
- Draft comment:
In the 'BrowserbaseExtensionArguments' definition, the title is given as 'Repositoryname'. For clarity and consistency, consider changing this to 'Repository Name'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. schemas/create_task_request.json:1320
- Draft comment:
In the 'BrowserbaseCreateSessionArguments' definition, the title for the 'extensionId' property is given as 'Extensionid'. Consider updating this to 'Extension ID' to improve readability. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_vKCvnjrfRpZUoVSJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
build_metadata_filter_conditionsthat safely builds SQL conditions from metadata filtersTest plan
Closes [Refactor]: Possible SQL Injection #1266
PR Type
Bug fix, Enhancement, Documentation
Description
Fixed potential SQL injection vulnerabilities in metadata filter queries.
build_metadata_filter_conditionsutility for safe SQL condition building.bulk_delete_docs,list_docs, andlist_agents.Updated
AlgoliaSearchArgumentsmodel to uselist[str]forattributes_to_retrieve.Enhanced documentation in
CLAUDE.mdwith updated instructions for maintaining directory-specific files.Updated schemas and TypeSpec files to align with new metadata filtering and Algolia model changes.
Changes walkthrough 📝
8 files
Updated `AlgoliaSearchArguments` model for attributes typeAdded utility for safe metadata filter condition buildingUpdated `AlgoliaSearchArguments` model for attributes typeAdjusted Algolia search request to use updated attributes typeAdded `BulkDeleteDocsRequest` schema for metadata filteringAdded `BulkDeleteDocsRequest` schema for metadata filteringUpdated TypeSpec for `AlgoliaSearchArguments` attributes typeUpdated OpenAPI spec for bulk delete and Algolia attributes3 files
Refactored metadata filtering logic for listing agentsRefactored metadata filtering logic for bulk document deletionRefactored metadata filtering logic for listing documents2 files
Added clarification on `workflow` usage in parallel executionEnhanced instructions for maintaining directory-specific documentationImportant
Fixes SQL injection vulnerabilities in metadata filter queries by introducing a safe SQL condition utility and refactoring affected queries.
build_metadata_filter_conditionsinutils.pyto prevent SQL injection in metadata filter queries.bulk_delete_docs,list_docs, andlist_agentsto use the new utility function.attributes_to_retrieveinAlgoliaSearchArgumentsfromdict[str, Any]tolist[str]inTools.pyandalgolia.py.CLAUDE.mdwith instructions for maintaining directory-specific files.create_agent_request.jsonandcreate_task_request.jsonfor new metadata filtering.algolia.tspandopenapi-1.0.0.yamlto align with model changes.test_agent_metadata_filtering.py,test_docs_metadata_filtering.py, andtest_metadata_filter_utils.py.This description was created by
for f4d252f. It will automatically update as commits are pushed.