Skip to content

support for func arg use check in SL #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2020
Merged

support for func arg use check in SL #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
843a22c
support for func arg use check in SL
ZacLN May 7, 2020
27de4bb
Merge branch 'master' into farguse
ZacLN May 7, 2020
eac9a19
bump dep ver
ZacLN May 7, 2020
698efbd
Merge branch 'master' into farguse
ZacLN May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/protocol/basic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,8 @@ const DiagnosticSeverities = (Error = 1,
Hint = 4)

const DiagnosticTag = Int
const DiagnosticTags = (Error = 1,
Warning = 2,
Information = 3,
Hint = 4)
const DiagnosticTags = (Unnecessary = 1,
Deprecated = 2)

struct DiagnosticRelatedInformation
location::Location
Expand Down
6 changes: 5 additions & 1 deletion src/requests/textdocument.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,11 @@ function mark_errors(doc, out = Diagnostic[])
elseif CSTParser.isidentifier(errs[i][2]) && !StaticLint.haserror(errs[i][2])
push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Warning, "Julia", "Julia", "Missing reference: $(errs[i][2].val)", missing, missing))
elseif StaticLint.haserror(errs[i][2]) && StaticLint.errorof(errs[i][2]) isa StaticLint.LintCodes
push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Information, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), missing, missing))
if StaticLint.errorof(errs[i][2]) === StaticLint.UnusedFunctionArgument
push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Hint, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), [DiagnosticTags.Unnecessary], missing))
else
push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Information, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), missing, missing))
end
end
i += 1
i>n && break
Expand Down
1 change: 1 addition & 0 deletions src/requests/workspace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ function request_julia_config(server)
response[N + 7]===nothing ? false : response[N + 7],
response[N + 8]===nothing ? false : response[N + 8],
response[N + 9]===nothing ? false : response[N + 9],
response[N + 10]===nothing ? false : response[N + 10],
)

new_run_lint_value = x===nothing ? false : true
Expand Down