Skip to content

Conversation

@tkgroot
Copy link

@tkgroot tkgroot commented Feb 11, 2022

replace helper function arrayContains with build-in Array.includes function

@Pulse-Git
Copy link

@tkgroot not supported by IE11

@tkgroot
Copy link
Author

tkgroot commented Aug 2, 2022

Maybe a good idea to drop IE11 support or let it be handled by polyfills?
Also if you look ahead IE11 doesn't support ESM, so it's just a big hurdle to keep the support for it

Signed-off-by: Tobias Kuppens Groot <tkuppensgroo@uos.de>
@tkgroot tkgroot force-pushed the feat/replace-array-contains branch from 6bad8f7 to 3cc6858 Compare January 4, 2023 12:48
@juliangarnier
Copy link
Owner

Sorry for the wait, v4 now uses Array.includes.

Check out the new documentation and the migration guide from v3.

I'm closing this for now, but feel free to re-open if this is still an issue for you in v4 by following the contributing guidelines.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants