Switching to Bible AI API #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced legacy scraping-based passage retrieval with API call to `query.verses`. - Added new `search` command using `query.words`. - Added new `ask` command using `query.prompt`. - Defined API models in `pkg/app/api_models.go`. - Created API client in `pkg/app/api_client.go`. - Deprecated legacy passage retrieval functions in `pkg/app/passage.go`. - Updated `pkg/app/command.go` and `pkg/app/const.go` to support new commands. - Initialized `AGENTS.md` with architecture and development guidelines.
Integrate Bible AI API and add Search/Ask commands
Add unit tests for api_client, api_models, ask, search, and passage
- Add `cloud.google.com/go/secretmanager` dependency. - Create `pkg/utils/secrets.go` to fetch secrets from Google Cloud Secret Manager. - Update `pkg/app/api_client.go` to check `GOOGLE_CLOUD_PROJECT` and fetch credentials from Secret Manager if environment variables are missing. - Implement caching in `getAPIConfig` to avoid repeated Secret Manager calls. - Add `resetAPIConfigCache` helper for testing. - Update `pkg/app/test_utils_test.go` to reset config cache when setting mock env vars. - Add `TestGetAPIConfig_SecretManagerFallback` to verify fallback logic.
Add Secret Manager support for API credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.