Drop MPB wrapper #60
Merged
Drop MPB wrapper #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 49.53% 47.92% -1.61%
==========================================
Files 10 9 -1
Lines 745 676 -69
==========================================
- Hits 369 324 -45
+ Misses 376 352 -24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are dependencies issues that SemidefiniteModels requires Compat v1 while the latest version of Compat, see
https://travis-ci.com/github/jump-dev/SumOfSquares.jl/jobs/404310450#L486-L498
Let's just drop the MPB wrapper as it's becoming a burden.