Skip to content

add Manifest and Project files #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add Manifest and Project files #556

wants to merge 1 commit into from

Conversation

chriscoey
Copy link
Contributor

@chriscoey chriscoey commented Nov 3, 2018 •
edited
Loading

to make running tests with latest Julia easy

@codecov-io
Copy link

codecov-io commented Nov 3, 2018 •
edited
Loading

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #556   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          47       47           
  Lines        4787     4787           
=======================================
  Hits         4576     4576           
  Misses        211      211

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34269f1...abe1b08. Read the comment docs.

@blegat
Copy link
Member

blegat commented Nov 3, 2018

Why do we have so much entries in Manifest.toml ? Is that Compat dependencies ?

@chriscoey
Copy link
Contributor Author

yeah I think so (it was automatically generated by pkg)

@mlubin
Copy link
Member

mlubin commented Nov 3, 2018 via email

odow
odow reviewed Nov 3, 2018
View reviewed changes
Project.toml

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where/why do we need Unicode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, pkg told me to add it. Worth investigating

mlubin
mlubin reviewed Nov 3, 2018
View reviewed changes
Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need a manifest file? I don't understand the purpose for registered packages where the package manager will resolve dependencies.

Manifest.toml
deps = ["Base64", "Dates", "DelimitedFiles", "Distributed", "InteractiveUtils", "LibGit2", "Libdl", "LinearAlgebra", "Markdown", "Mmap", "Pkg", "Printf", "REPL", "Random", "Serialization", "SharedArrays", "Sockets", "SparseArrays", "Statistics", "Test", "UUIDs", "Unicode"]
git-tree-sha1 = "2d9e14d19bad3f9ad5cc5e4cffabc3cfa59de825"
uuid = "34da2185-b29b-5c13-b0c7-acf172513d20"
version = "1.3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the procedure for maintaining this file? Do we have to manually Pkg.update() when Compat gets updated?

Copy link
Member

@odow odow Nov 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest.toml gets updated automatically when you run Pkg operations locally in this project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yes, this requires manual updates. In what workflow do you need a manifest file for the package? Pkg.test doesn't require it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use a Manifest.toml so that my travis builds against JuMP master. I couldn't figure out how to do this in Project.toml:
https://github.com/odow/Kokako.jl/blob/d6e48925b450de46f3fa17adf494c10deca59471/Manifest.toml#L86-L92

Project.toml
@@ -0,0 +1,7 @@
name = "MathOptInterface"
uuid = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
version = "0.6.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this version get updated when we tag a new MOI?

Project.toml
name = "MathOptInterface"
uuid = "b8f27783-ece8-5eb3-8dc8-9495eed66fee"
version = "0.6.2"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a compatibility section specifying the allowed versions of Compat and julia.

@chriscoey
Copy link
Contributor Author

I have all the same questions. And yes perhaps we don't need the Manifest.

Anyone feel free to modify or replace this PR. Probably worth pinging Pkg3 devs on Slack.

@mlubin mlubin mentioned this pull request Dec 1, 2018
Closed
@chriscoey
Copy link
Contributor Author

Closing in favor of #714

@chriscoey chriscoey closed this Apr 19, 2019
@chriscoey chriscoey deleted the addprojectmanifest branch August 7, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlubin mlubin mlubin left review comments

@odow odow odow left review comments

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chriscoey @codecov-io @blegat @mlubin @odow