Skip to content

Conversation

matbesancon
Copy link
Contributor

Added a Project.toml file with compatible UUID and corresponding dependencies, removed use of Compat

@blegat
Copy link
Member

blegat commented Apr 19, 2019

There are also VERSION checks to remove:

➜  MathOptInterface git:(master) ✗ grep VERSION * -r
src/functions.jl:@static if VERSION >= v"0.7-"
src/functions.jl:if VERSION < v"0.7-"
src/functions.jl:        if VERSION >= v"0.7-"
src/functions.jl:        if VERSION >= v"0.7-"
src/Utilities/functions.jl:    @static if VERSION >= v"0.7-"
src/Utilities/functions.jl:    @static if VERSION >= v"0.7-"
src/Utilities/functions.jl:@static if VERSION >= v"0.7-"
src/Utilities/model.jl:if VERSION >= v"0.7.0-DEV.2813"
src/Utilities/parser.jl:if VERSION > v"0.7-"
src/Utilities/model.jl.mem:        - if VERSION >= v"0.7.0-DEV.2813"
src/attributes.jl:@static if VERSION >= v"0.7-"
src/Test/modellike.jl:        if VERSION < v"0.7-"
src/Test/modellike.jl:        if VERSION < v"0.7-"
src/Bridges/quadtosocbridge.jl:        @static if VERSION >= v"0.7-"
src/MathOptInterface.jl:VERSION < v"0.7.0-beta2.199" && __precompile__()
src/MathOptInterface.jl:@static if VERSION >= v"0.7-"
test/bridge.jl:        if VERSION < v"0.7-"
test/bridge.jl:        if VERSION < v"0.7-"
test/bridge.jl:        if VERSION < v"0.7-"
test/Utilities/cachingoptimizer.jl:    if VERSION < v"0.7"
test/Utilities/mockoptimizer.jl:    if VERSION < v"0.7-"
test/Utilities/mockoptimizer.jl:    if VERSION < v"0.7-"
test/attributes.jl:        if VERSION < v"0.7-"

@matbesancon matbesancon mentioned this pull request Apr 19, 2019
2 tasks
@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

Merging #714 into master will decrease coverage by 2.81%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
- Coverage    95.2%   92.39%   -2.82%     
==========================================
  Files          54       54              
  Lines        5690     5652      -38     
==========================================
- Hits         5417     5222     -195     
- Misses        273      430     +157
Impacted Files Coverage Δ
src/Test/Test.jl 100% <ø> (ø) ⬆️
src/Utilities/Utilities.jl 100% <ø> (ø) ⬆️
src/Utilities/model.jl 93.72% <ø> (-6.28%) ⬇️
src/Bridges/Bridges.jl 100% <ø> (ø) ⬆️
src/Test/contconic.jl 99% <ø> (-1%) ⬇️
src/Bridges/intervalbridge.jl 80.55% <0%> (-5.56%) ⬇️
src/Bridges/squarepsdbridge.jl 91.93% <0%> (-6.46%) ⬇️
src/Utilities/copy.jl 91.08% <0%> (-1.99%) ⬇️
src/Bridges/quadtosocbridge.jl 90.47% <100%> (-6.5%) ⬇️
src/Utilities/functions.jl 91.27% <100%> (-4.13%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b515886...46c15f1. Read the comment docs.

@matbesancon
Copy link
Contributor Author

Not sure codecov is very meaningful here

@matbesancon
Copy link
Contributor Author

Fixes #661

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@blegat
Copy link
Member

blegat commented Apr 19, 2019

Not sure codecov is very meaningful here

Not it's know that dropping Julia v0.6 creates a coverage drop: JuliaCI/Coverage.jl#187

@blegat blegat merged commit af63a2d into jump-dev:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants