Skip to content

Conversation

joaquimg
Copy link
Member

@joaquimg joaquimg commented Dec 28, 2018

Basic implementation finished. Waiting for comments.

@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #610 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage    95.2%   95.28%   +0.08%     
==========================================
  Files          48       49       +1     
  Lines        5130     5391     +261     
==========================================
+ Hits         4884     5137     +253     
- Misses        246      254       +8
Impacted Files Coverage Δ
src/Test/contlinear.jl 100% <ø> (ø) ⬆️
src/Bridges/bridgeoptimizer.jl 99.03% <ø> (+1.92%) ⬆️
src/Bridges/slackbridge.jl 100% <100%> (ø)
src/Utilities/functions.jl 97.59% <100%> (+0.42%) ⬆️
src/Bridges/Bridges.jl 100% <100%> (ø) ⬆️
src/Utilities/mockoptimizer.jl 96.49% <0%> (-0.89%) ⬇️
src/Utilities/cachingoptimizer.jl 90.43% <0%> (-0.3%) ⬇️
src/sets.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f899f30...d6788e4. Read the comment docs.

@blegat
Copy link
Member

blegat commented Dec 28, 2018

Still not sure about how to test the bridges. Can I create a model with @model that supports ScalarAffineFunction-in-EqualTo but not -in-LessThan?

You can run it through some contlinear tests. The underlying model of the mockoptimizer may support the constraint that is bridged that is not an issue as the SingleBridgeOptimizer bridges all the constraints it can bridge regardless of whether it is supported or not (which is appropriate for testing), as opposed to LazyBridgeOptimizer which is used in JuMP.

operate does not work on vector functions for addition, what should I do?

The missing operate methods should be added

@joaquimg
Copy link
Member Author

PS there is a bunch of indentation mistakes.
VSCode is very annoying, I wanted to have an idea if this is in the right direction and then I will fix style :)

@joaquimg
Copy link
Member Author

It should be almost finished, I might need to fix style and add operate tests

@joaquimg
Copy link
Member Author

There is something about test_delete_bridge.
It assumes no variable was added by the bridge?

@blegat
Copy link
Member

blegat commented Jan 21, 2019

There is something about test_delete_bridge.
It assumes no variable was added by the bridge?

You need to implement NumberOfVariables to so that the bridgeoptimizer can adjust the number of variables to ignore the ones created by the bridge. See GeoMeanBridge.

@joaquimg
Copy link
Member Author

It's alive!

@joaquimg joaquimg changed the title WIP: Slack bridges Add Slack bridges Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants