Skip to content

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 17, 2019

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #634 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #634      +/-   ##
=========================================
+ Coverage    95.2%   95.2%   +<.01%     
=========================================
  Files          48      48              
  Lines        5128    5130       +2     
=========================================
+ Hits         4882    4884       +2     
  Misses        246     246
Impacted Files Coverage Δ
src/Utilities/functions.jl 97.17% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63ab44...183448a. Read the comment docs.

@blegat blegat merged commit f899f30 into master Jan 18, 2019
@mlubin
Copy link
Member

mlubin commented Jan 18, 2019

I should have taken a look at this earlier. We should not be using Base.zero() for mutable types (jump-dev/JuMP.jl#1151). Consider creating a new function instead of extending Base.zero.

@blegat
Copy link
Member Author

blegat commented Jan 18, 2019

Sorry for merging without review, I needed the changes of this PR and #610 at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants