Skip to content

Slightly improve a tolerance issue in KirlikSayin #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 4 commits into from
May 5, 2026
+3 −3
Merged

Slightly improve a tolerance issue in KirlikSayin #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6e36af
Slightly improve a tolerance issue in KirlikSayin
odow May 5, 2026
1e6d94e
Apply suggestion from @odow
odow May 5, 2026
729d7a6
Update log line checks in test_model.jl
odow May 5, 2026
58b61f3
Apply suggestion from @odow
odow May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/algorithms/KirlikSayin.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function minimize_multiobjective!(
zₖ_constraint = MOI.Utilities.normalize_and_add_constraint(
inner,
scalars[k],
MOI.EqualTo(zₖ),
MOI.LessThan(zₖ),
)
optimize_inner!(model)
if !_is_scalar_status_optimal(model)
Expand Down
4 changes: 2 additions & 2 deletions test/test_model.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,12 +258,12 @@ function test_printing()
return
end
contents = read(joinpath(dir, "log.txt"), String)
for line in [
for line in Any[
"Algorithm: KirlikSayin",
"1 0.00000e+00 0.00000e+00",
"----------------------------------------------",
"termination_status: OPTIMAL",
"result_count: 10",
r"result_count: [0-9]+",
"Time spent in subproblems: ",
]
@test occursin(line, contents)
Expand Down
Loading