Avoid Windows tar drive-letter paths#312
Merged
Merged
Conversation
Git Bash on windows-latest expands RUNNER_TEMP to a drive-letter path. GNU tar treats paths containing a colon as remote archive syntax, so extracting the encrypted brand archive failed before the assets could be applied. Constraint: The brand asset step runs with shell bash across macOS, Linux, and Windows runners Constraint: Windows Git Bash paths such as D:\... are unsafe for tar -xzf Rejected: Keep using RUNNER_TEMP | tar misinterprets the drive letter as a remote host separator on Windows Confidence: high Scope-risk: narrow Directive: Keep brand asset temporary archive paths relative unless the extraction command is made Windows-path aware Tested: Local openssl decrypt plus tar extract plus apply-brand-assets smoke copied 10 assets using relative .brand-assets-tmp paths Not-tested: Full GitHub Actions windows-latest build Co-authored-by: OmX <omx@oh-my-codex.dev>
feng626
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git Bash on windows-latest expands RUNNER_TEMP to a drive-letter path. GNU tar treats paths containing a colon as remote archive syntax, so extracting the encrypted brand archive failed before the assets could be applied.
Constraint: The brand asset step runs with shell bash across macOS, Linux, and Windows runners
Constraint: Windows Git Bash paths such as D:... are unsafe for tar -xzf
Rejected: Keep using RUNNER_TEMP | tar misinterprets the drive letter as a remote host separator on Windows
Confidence: high
Scope-risk: narrow
Directive: Keep brand asset temporary archive paths relative unless the extraction command is made Windows-path aware
Tested: Local openssl decrypt plus tar extract plus apply-brand-assets smoke copied 10 assets using relative .brand-assets-tmp paths
Not-tested: Full GitHub Actions windows-latest build