-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for aarch64 platform #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request introduces two key modifications. The GitHub Actions workflow for end-to-end testing is updated to use a matrix strategy, allowing tests to run concurrently on both Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant R1 as Runner (Ubuntu-24.04)
participant R2 as Runner (Ubuntu-24.04-arm)
Dev->>GH: Push commit
GH->>R1: Trigger e2e-tests on Ubuntu-24.04
GH->>R2: Trigger e2e-tests on Ubuntu-24.04-arm
R1-->>GH: Report test results
R2-->>GH: Report test results
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/secrets-job.yaml (1)
25-26: Consistency in Namespace Flag FormatThe commands now use
kubectlfor secret management—which is great—but there is an inconsistency in how the namespace flag is specified. Line 25 uses:-n {{ $namespace }}while line 26 uses:
-n={{ $namespace }}Standardizing to a single format (for example,
-n {{ $namespace }}) might prevent potential parsing issues..github/workflows/e2e.yaml (1)
22-27: Clarify the Need for Duplicate e2e Test JobThere are two e2e test jobs defined: one using the new matrix strategy and another using a fixed
ubuntu-latestrunner. If both jobs serve distinct purposes or are intended to cover separate scenarios, please consider adding comments to clarify the rationale. Otherwise, you might consolidate these jobs for easier maintenance.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/e2e.yaml(1 hunks)deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/secrets-job.yaml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/e2e.yaml
14-14: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
🔇 Additional comments (2)
deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/secrets-job.yaml (1)
18-18: Container Image Update VerifiedThe container image has been updated to
quay.io/jumpstarter-dev/jumpstarter-utils:latest, which aligns with the migration away from OpenShift CLI. Please ensure that this new image is validated in your deployment tests on all supported platforms..github/workflows/e2e.yaml (1)
10-15:❓ Verification inconclusive
Matrix Strategy with Potential Runner Label Issue
The new matrix strategy for the
e2e-testsjob (covering bothubuntu-24.04andubuntu-24.04-arm) is a solid approach for enabling concurrent testing, which supports the aarch64 platform objective. However, static analysis indicates that the labelubuntu-24.04-armmay not be recognized by available runner configurations. Verify that your self-hosted or cloud runner setup accepts this custom label. If not, consider switching to a supported label (such asarmorarm64) to ensure tests run correctly.
Below is a shell script that searches the repository for any occurrences of
"ubuntu-24.04-arm". Running this can help verify if the custom runner label is defined or referenced elsewhere (for example, in custom self-hosted runner configurations). If the search turns up no additional configuration that explicitly supports"ubuntu-24.04-arm", you may need to update the label to one that is recognized (e.g.,"arm"or"arm64").Once you review the output of this script:
- If you find that your infrastructure explicitly defines or supports
"ubuntu-24.04-arm", you can safely ignore this concern.- Otherwise, consider updating the label to one supported by your runner configuration.
Verify Custom Runner Label in GitHub Actions Workflow
🏁 Script executed:
#!/bin/bash # Search the entire repository for occurrences of the custom runner label "ubuntu-24.04-arm" rg "ubuntu-24.04-arm" -n .Length of output: 148
Below is a new shell script to narrow the search specifically within the workflow file to confirm the occurrence of the custom runner label:
Based on prior results and the absence of additional configuration references in the repository, it appears that “ubuntu-24.04-arm” is only mentioned in the workflow file. Please manually verify that your self-hosted or cloud runner setup supports this custom label. If your runner configuration does not recognize it, consider switching to a supported label (such as
armorarm64) so that the tests can run correctly.Action:
- Confirm the runner configuration supports the custom label
ubuntu-24.04-arm.- If not, update the workflow to use a recognized label (e.g.,
armorarm64).
🏁 Script executed:
#!/bin/bash # Check for "ubuntu-24.04-arm" specifically within the e2e workflow file grep -n "ubuntu-24.04-arm" .github/workflows/e2e.yaml || echo "Custom label not found in .github/workflows/e2e.yaml"Length of output: 207
Matrix Strategy: Confirm Custom Runner Label
The workflow file
.github/workflows/e2e.yamluses the "ubuntu-24.04-arm" label within the matrix strategy (specifically at line 14). Our repository search confirms that this label appears only in this file, and there’s no additional configuration indicating explicit support for it.
- File:
.github/workflows/e2e.yaml(lines 10–15)- Action Required: Manually verify that your self-hosted or cloud runner configuration accepts the custom label "ubuntu-24.04-arm". If it isn’t supported, update the label to a recognized one (e.g., "arm" or "arm64") to ensure that tests run correctly.
🧰 Tools
🪛 actionlint (1.7.4)
14-14: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
Summary by CodeRabbit
Tests
Chores