Fix e2e test

[NickCao]

Summary by CodeRabbit

• Workflow Changes

  • Simplified end-to-end testing workflow
  • Replaced manual checkout with dedicated testing action
  • Removed input parameter requirements

• Build Process

  • Added grpcurl tool to deployment workflow
  • Enhanced deployment script flexibility

• Deployment

  • Updated deployment script to use configurable gRPC URL tool
  • Improved endpoint readiness checking mechanism

[coderabbitai]

Walkthrough

The pull request introduces modifications to the end-to-end testing workflow, Makefile, and deployment script. The changes primarily focus on streamlining the E2E testing process by using a dedicated GitHub Action, adding support for the grpcurl tool in the build system, and enhancing the deployment script's flexibility for gRPC endpoint checks. These updates aim to simplify workflow configurations and provide more adaptable tooling for deployment and testing processes.

Changes

File	Changes
.github/workflows/e2e.yaml	- Removed inputs section - Replaced checkout action with jumpstarter-dev/jumpstarter-e2e@main - Added controller-ref and jumpstarter-ref parameters
Makefile	- Added GRPCURL and GRPCURL_VERSION variables - Created new grpcurl phony target - Modified deploy target to depend on grpcurl
hack/deploy_with_helm.sh	- Added GRPCURL environment variable - Updated gRPC endpoint check to use ${GRPCURL} instead of hardcoded podman command

Sequence Diagram

sequenceDiagram
    participant Workflow as GitHub Workflow
    participant E2EAction as Jumpstarter E2E Action
    participant Controller as Repository Controller
    
    Workflow->>E2EAction: Trigger with refs
    E2EAction->>Controller: Checkout using specified refs
    E2EAction-->>Workflow: Run E2E Tests

Loading

Poem

🐰 Hopping through workflows with glee,
Grpcurl in paw, testing's the key!
Simplified actions, no more delay,
Deployment's smoother every day.
Rabbit's tech magic is here to stay! 🚀

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

hack/deploy_with_helm.sh (1)

112-112: Consider enhancing error handling for grpcurl execution.

While the change removes the podman dependency, it would be beneficial to add error handling for cases where grpcurl execution fails for reasons other than endpoint unavailability.

-    while ! ${GRPCURL} -insecure ${ep} list; do
+    while ! ${GRPCURL} -insecure ${ep} list 2>/dev/null; do
+        if [ $? -eq 127 ]; then
+            echo "Error: grpcurl not found or not executable at ${GRPCURL}"
+            exit 1
+        fi

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d7a09cd and a07fb54.

📒 Files selected for processing (3)

• .github/workflows/e2e.yaml (1 hunks)
• Makefile (4 hunks)
• hack/deploy_with_helm.sh (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: e2e-tests
• GitHub Check: deploy-kind

🔇 Additional comments (5)

.github/workflows/e2e.yaml (1)

12-15: LGTM! Workflow simplified using dedicated action.

The change streamlines the E2E testing process by:

• Removing manual input requirements
• Replacing manual setup with a dedicated action
• Properly configuring references for controller and jumpstarter

hack/deploy_with_helm.sh (1)

6-6: LGTM! Added configurable GRPCURL variable.

The change allows customizing the grpcurl tool path while providing a sensible default.

Makefile (3)

124-124: LGTM! Updated deploy dependencies.

The change correctly adds grpcurl as a dependency for the deploy target.

---

155-155: LGTM! Added GRPCURL variable and version.

The change follows the established pattern for tool variables and versions.

Also applies to: 164-164

---

191-195: LGTM! Added grpcurl installation target.

The change properly implements the grpcurl installation using the existing go-install-tool pattern.