Skip to content

Conversation

@bennyz
Copy link
Member

@bennyz bennyz commented Apr 27, 2025

Summary by CodeRabbit

  • Chores
    • Improved build workflow to support multi-platform Docker images and dynamic tagging for release branches.
    • Enhanced Helm chart publishing to include branch-specific tags for release branches.

@bennyz bennyz requested a review from Copilot April 27, 2025 11:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 27, 2025

Walkthrough

The GitHub Actions workflow configuration was updated to enhance the build and deployment process. The workflow now triggers on both the main branch and any branch matching the release-* pattern. Steps were added to dynamically set Docker image tags based on the branch type, supporting tagging for version, latest, and specific release branches. The Docker image build and push process now uses the docker/build-push-action@v6 for multi-platform builds with caching. Additional setup for QEMU and Docker Buildx was included. The helm chart publishing job was also updated to handle release branch tagging.

Changes

File(s) Change Summary
.github/workflows/build.yaml Updated workflow triggers to include release-* branches; added dynamic Docker image tagging; replaced build and push step with docker/build-push-action@v6 for multi-platform support; added QEMU and Buildx setup steps; updated helm chart publishing to handle release branch tags.

Poem

A bunny builds with nimble paws,
Now tags for every branch and cause!
Multi-platform dreams take flight,
With QEMU magic, day and night.
Helm charts hop with branchy flair—
Release or main, we’re everywhere!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2a430f1 and 873ab82.

📒 Files selected for processing (1)
  • .github/workflows/build.yaml (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: e2e-tests (ubuntu-24.04-arm)
  • GitHub Check: tests
  • GitHub Check: e2e-tests (ubuntu-24.04)
  • GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
  • GitHub Check: deploy-kind
  • GitHub Check: lint-go
🔇 Additional comments (2)
.github/workflows/build.yaml (2)

9-9: Approve trigger addition for release branches
Adding release-* to the push branches ensures the workflow will run on all release branches as intended. The YAML quoting is correct to prevent alias parsing for the wildcard.


64-72: Docker build-and-push step looks good
The upgrade to docker/build-push-action@v6 with multi-platform support, cache-from/cache-to configuration, and dynamic tags is correctly set up.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds logic to handle release branches during build and helm chart publishing.

  • Trigger workflows on branches matching "release-*".
  • Conditionally set image tags for main and release branches.
  • Add helm chart saving and pushing when on a release branch.

TAGS="$TAGS,${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest"
fi
if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then
Copy link

Copilot AI Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For pattern matching against release branches, consider quoting the wildcard segment appropriately (e.g., "refs/heads/release-"*). This ensures that the shell correctly interprets the wildcard.

Suggested change
if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then
if [[ "${{ github.ref }}" == "refs/heads/release-"* ]]; then

Copilot uses AI. Check for mistakes.
run: |
helm push jumpstarter-*.tgz oci://${{ env.QUAY_ORG }}/helm
if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then
Copy link

Copilot AI Apr 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, adjust the pattern matching in the helm chart push section by quoting the wildcard portion (e.g., "refs/heads/release-"*) to ensure reliable matching.

Suggested change
if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then
if [[ "${{ github.ref }}" == "refs/heads/release-"* ]]; then

Copilot uses AI. Check for mistakes.
@mangelajo
Copy link
Member

@bennyz let me know when it's ready, and let's merge it

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz bennyz marked this pull request as ready for review April 29, 2025 12:43
@mangelajo mangelajo merged commit e9172df into jumpstarter-dev:main May 8, 2025
8 checks passed
@mangelajo mangelajo added backport-release-0.6 backport release-0.6 Trigger a backport PR to release-0.6 branch and removed backport-release-0.6 labels May 8, 2025
@jumpstarter-backport-bot
Copy link

Successfully created backport PR for release-0.6:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-0.6 Trigger a backport PR to release-0.6 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants