-
Notifications
You must be signed in to change notification settings - Fork 9
actions: add release logic #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions workflow configuration was updated to enhance the build and deployment process. The workflow now triggers on both the main branch and any branch matching the release-* pattern. Steps were added to dynamically set Docker image tags based on the branch type, supporting tagging for version, latest, and specific release branches. The Docker image build and push process now uses the docker/build-push-action@v6 for multi-platform builds with caching. Additional setup for QEMU and Docker Buildx was included. The helm chart publishing job was also updated to handle release branch tagging. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds logic to handle release branches during build and helm chart publishing.
- Trigger workflows on branches matching "release-*".
- Conditionally set image tags for main and release branches.
- Add helm chart saving and pushing when on a release branch.
.github/workflows/build.yaml
Outdated
| TAGS="$TAGS,${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest" | ||
| fi | ||
| if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then |
Copilot
AI
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For pattern matching against release branches, consider quoting the wildcard segment appropriately (e.g., "refs/heads/release-"*). This ensures that the shell correctly interprets the wildcard.
| if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then | |
| if [[ "${{ github.ref }}" == "refs/heads/release-"* ]]; then |
.github/workflows/build.yaml
Outdated
| run: | | ||
| helm push jumpstarter-*.tgz oci://${{ env.QUAY_ORG }}/helm | ||
| if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then |
Copilot
AI
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, adjust the pattern matching in the helm chart push section by quoting the wildcard portion (e.g., "refs/heads/release-"*) to ensure reliable matching.
| if [[ "${{ github.ref }}" == refs/heads/release-* ]]; then | |
| if [[ "${{ github.ref }}" == "refs/heads/release-"* ]]; then |
|
@bennyz let me know when it's ready, and let's merge it |
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
|
Successfully created backport PR for |
Summary by CodeRabbit