Conversation
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
WalkthroughExtended the Mode enum to include "nodeport" in both the Python model and Helm values schema, expanding accepted values from ["ingress","route"] to ["ingress","route","nodeport"]. No additional logic or structural changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
deploy/helm/jumpstarter/charts/jumpstarter-controller/model.py (1)
225-229: Update docstring to mention NodePortTLS port description still says “Ingress or Route”; include NodePort for consistency.
Proposed change (outside this hunk):
port: Optional[Port] = Field( None, description="Port to use for the gRPC endpoints via Ingress, Route, or NodePort; useful for ingress routers on non-standard ports", )deploy/helm/jumpstarter/charts/jumpstarter-controller/values.schema.json (2)
910-921: Clarify TLS port description to include NodePortMirror the model/doc change so users aren’t misled.
Proposed snippet (outside this hunk):
"port": { "anyOf": [{ "$ref": "#/$defs/Port" }, { "type": "null" }], "default": null, "description": "Port to use for the gRPC endpoints via Ingress, Route, or NodePort; useful for ingress routers on non-standard ports" }
724-734: Optional: tighten NodePort range if routerPort maps to Service.spec.ports[].nodePortIf “routerPort” is a NodePort value, constrain to 30000–32767; otherwise ignore.
Proposed schema addition (outside this hunk):
"$defs": { "NodePort": { "minimum": 30000, "maximum": 32767, "title": "NodePort", "type": "integer" } }Then update:
"routerPort": { "anyOf": [ { "$ref": "#/$defs/NodePort" }, { "type": "null" } ], "default": null }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
deploy/helm/jumpstarter/charts/jumpstarter-controller/model.py(1 hunks)deploy/helm/jumpstarter/charts/jumpstarter-controller/values.schema.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: deploy-kind
- GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
- GitHub Check: e2e-tests (ubuntu-24.04)
- GitHub Check: e2e-tests (ubuntu-24.04-arm)
- GitHub Check: lint-go
- GitHub Check: tests
🔇 Additional comments (2)
deploy/helm/jumpstarter/charts/jumpstarter-controller/model.py (1)
59-63: Enum: added nodeport — LGTM; service templates already gate NodePort via .Values.grpc.nodeport.enableddeploy/helm/jumpstarter/charts/jumpstarter-controller/values.schema.json (1)
682-686: Mode enum extended with nodeport — LGTMSchema now matches the Python model.
2 participants
Summary by CodeRabbit