soc testing example usign pytest and imagehash#120
Conversation
mangelajo
force-pushed
the
pytest-with-imagehash
branch
from
9cb783b to
6f9c0da
Compare
mangelajo
force-pushed
the
pytest-with-imagehash
branch
4 times, most recently
from
b07dc62 to
7742a37
Compare
mangelajo
force-pushed
the
pytest-with-imagehash
branch
2 times, most recently
from
fd04e70 to
18c053a
Compare
mangelajo
force-pushed
the
imagehash-lib
branch
from
43aabe2 to
4c1b38a
Compare
mangelajo
force-pushed
the
pytest-with-imagehash
branch
from
18c053a to
f7ade45
Compare
mangelajo
changed the title
mangelajo
force-pushed
the
pytest-with-imagehash
branch
from
f7ade45 to
6519cee
Compare
mangelajo
force-pushed
the
pytest-with-imagehash
branch
2 times, most recently
from
4a4359d to
c09297a
Compare
mangelajo
force-pushed
the
pytest-with-imagehash
branch
from
c09297a to
47fecd5
Compare
| # TODO: figure this out | ||
| #"jumsptarter_imagehash", | ||
| #"jumpstarter_driver_dutlink", |
There was a problem hiding this comment.
If you can try to uncomment it locally, it doesn't seem to work.
There was a problem hiding this comment.
It was a typo: jumpstarter-dev/jumpstarter#132
| :rtype: pexpect.spawn | ||
| """ | ||
| log.info("Waiting for login prompt") | ||
| pexpect_console.expect("login:", timeout=timeout) |
There was a problem hiding this comment.
This should be part of the example, the login prompts could be different across distributions.
There was a problem hiding this comment.
I am OK with moving it to the example, but we should have a generic shell driver/adapter in the long term to help us drive the login/shell interaction with a common interface.
Probably to put in in the core we should make it ready to handle all those other case
| def test_power_on_hdmi(self, client, video): | ||
| # check all the image snapshots through the rpi4 boot process | ||
| client.dutlink.power.on() | ||
| time.sleep(1) |
There was a problem hiding this comment.
I'm a little concerned about timing, how has this been reliability-wise?
There was a problem hiding this comment.
surprisingly reliable, but yes, this should not be the end goal :)
just a starting point. As we said, something that is going to compare video input and expect images to appear in a specific order, and finally provide a list of appearances, and timestamps, probably running on the exporter itself?
There was a problem hiding this comment.
I'm not quite sure if we should put this in core, I feel like while this is common for many Linux systems, it may not be useful for many users who won't get a login prompt or may get a different message.
There was a problem hiding this comment.
I'll move it into the example itself, until we can create a more common adapter for driving shell/login interaction.
|
I'll merge for now and follow up with your comments in a separate PR, thanks for reviewing and the meaningful requests. |
3 participants
Provides a SOC testing example involving drivers like dutlink and ustreamer, console, storage, etc..