Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Lease expiration notification#360

Merged
mangelajo merged 1 commit intomainfrom
lease-expiration-notification
Mar 19, 2025
Merged

Lease expiration notification#360
mangelajo merged 1 commit intomainfrom
lease-expiration-notification

Conversation

@NickCao
Copy link
Copy Markdown
Collaborator

@NickCao NickCao commented Mar 19, 2025

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 19, 2025

Warning

Rate limit exceeded

@NickCao has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d149734 and 6291d51.

📒 Files selected for processing (4)
  • packages/jumpstarter-cli-admin/jumpstarter_cli_admin/get_test.py (2 hunks)
  • packages/jumpstarter-cli-client/jumpstarter_cli_client/client_shell.py (1 hunks)
  • packages/jumpstarter/jumpstarter/client/grpc.py (3 hunks)
  • packages/jumpstarter/jumpstarter/client/lease.py (5 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 19, 2025

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit 6291d51
🔍 Latest deploy log https://app.netlify.com/sites/jumpstarter-docs/deploys/67daf943e983e90008784990
😎 Deploy Preview https://deploy-preview-360--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickCao
Copy link
Copy Markdown
Collaborator Author

NickCao commented Mar 19, 2025

Closes jumpstarter-dev/jumpstarter#337

@NickCao NickCao force-pushed the lease-expiration-notification branch from a69c64a to c2d3657 Compare March 19, 2025 17:04
@NickCao NickCao force-pushed the lease-expiration-notification branch from c2d3657 to 6291d51 Compare March 19, 2025 17:05
@mangelajo
Copy link
Copy Markdown
Member

Nice, I manually tested by setting timedelta to 29min

➜  jumpstarter git:(lease-expiration-notification) ✗ uv run jmp  client shell -l microcontroller pico2350w
Installed 4 packages in 5ms
INFO:jumpstarter.client.lease:Created lease request for selector microcontroller=pico2350w for duration 0:30:00
➜  jumpstarter git:(lease-expiration-notification) ✗
➜  jumpstarter git:(lease-expiration-notification) ✗
➜  jumpstarter git:(lease-expiration-notification) ✗ date
Wed Mar 19 19:39:56 CET 2025
➜  jumpstarter git:(lease-expiration-notification) ✗
➜  jumpstarter git:(lease-expiration-notification) ✗ date
Wed Mar 19 19:40:05 CET 2025

➜  jumpstarter git:(lease-expiration-notification) ✗ date
Wed Mar 19 19:40:52 CET 2025
➜  jumpstarter git:(lease-expiration-notification) ✗ INFO:jumpstarter.client.lease:Lease 0195afb4-731c-7da0-b85d-c99ee780fbfc ending soon in 0:28:59.208607 at 2025-03-19 20:09:53+01:00

@mangelajo mangelajo merged commit ab363e6 into main Mar 19, 2025
20 of 22 checks passed
@NickCao NickCao deleted the lease-expiration-notification branch March 19, 2025 21:06
@mangelajo mangelajo added this to the 0.6.0 milestone May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants