Make sure that no bash scripts override PS1, i.e. devspaces

[mangelajo]

Summary by CodeRabbit

• New Features
  • Enhanced shell launching behavior: Bash sessions now start without loading user configuration files, offering a cleaner and more consistent environment at launch.

[coderabbitai]

Walkthrough

The pull request modifies the launch_shell function in the utility module. The update revises how the command used to launch the shell is constructed. It now initializes the command with the shell from the environment and, if the shell is detected as "bash," it appends the options --norc and --noprofile to alter the shell’s startup behavior. The rest of the process execution and handling of environment variables remains unchanged.

Changes

File	Change Summary
packages/jumpstarter/.../utils.py	Updated launch_shell function: added a conditional check to detect "bash" and append --norc and --noprofile options to the command.

Sequence Diagram(s)

sequenceDiagram
    participant C as Caller
    participant L as launch_shell()
    participant E as Environment
    participant P as Process
    C->>L: Call launch_shell(host, context, allow, unsafe)
    L->>E: Retrieve SHELL (default "bash")
    alt Shell is "bash"
        L-->>L: Append "--norc", "--noprofile" to command
    end
    L->>P: Spawn process with constructed command
    P-->>L: Return process result
    L-->>C: Return exit code

Loading

Poem

I'm a hopping coder, small and spry,
Launching shells beneath the moonlit sky.
With --norc and --noprofile in tow,
My bash commands quickly grow.
CodeRabbit hops through changes with cheer,
Spreading joy in every line, far and near.
Happy coding, my dear!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 886f21a and 34f92a2.

📒 Files selected for processing (1)

• packages/jumpstarter/jumpstarter/common/utils.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (11)

• GitHub Check: Redirect rules - jumpstarter-docs
• GitHub Check: Header rules - jumpstarter-docs
• GitHub Check: Pages changed - jumpstarter-docs
• GitHub Check: pytest-matrix (3.13)
• GitHub Check: pytest-matrix (3.12)
• GitHub Check: pytest-matrix (3.11)
• GitHub Check: e2e
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-devspace .devfile/Containerfile.client)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-dev .devfile/Containerfile)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter Dockerfile)
• GitHub Check: build-and-push-image (jumpstarter-dev/jumpstarter-utils Dockerfile.utils)

🔇 Additional comments (1)

packages/jumpstarter/jumpstarter/common/utils.py (1)

92-96: Excellent fix to prevent PS1 overrides in bash

This change correctly prevents the custom Jumpstarter prompt from being overridden by user configuration files. By adding the --norc and --noprofile flags to bash, you're ensuring that neither .bashrc nor .bash_profile will be loaded, thus preserving the PS1 prompt setting specified in the environment variables.

The implementation is clean and properly handles different shell paths by checking if the shell name ends with "bash" rather than just checking for an exact match.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for jumpstarter-docs ready!

Name	Link
🔨 Latest commit	0eee75c
🔍 Latest deploy log	https://app.netlify.com/sites/jumpstarter-docs/deploys/67dd8d1c4aee4f0008d3ca1f
😎 Deploy Preview	https://deploy-preview-369--jumpstarter-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[NickCao]

Good enough for now, will make it customizable with a --command flag in the new unified cli.