This repository was archived by the owner on Jan 23, 2026. It is now read-only.
Update installer default branch to 0.7#616
Merged
Conversation
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughDEFAULT_SOURCE in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
0.6 referenced in https://github.com/jumpstarter-dev/jumpstarter/blob/0ad1f25fded23d9071b7b3175daac205deff3855/install.sh#L41-L56 maybe should be dynamic |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
install.sh (3)
41-56: Help/usage still mentions 0.6; derive from DEFAULT_SOURCE to avoid drift.Apply:
- -s, --source SOURCE Installation source (default: release-0.6) + -s, --source SOURCE Installation source (default: ${DEFAULT_SOURCE}) Available sources: - - release-0.6: Stable release 0.6 (recommended) + - ${DEFAULT_SOURCE}: Stable release ${DEFAULT_SOURCE#release-} (recommended) - latest: Latest stable release (when available) - rc: Latest release candidate (when available) - main: Latest development version @@ - $0 # Install stable release 0.6 (recommended) - $0 -s release-0.6 # Install stable release 0.6 + $0 # Install stable release ${DEFAULT_SOURCE#release-} (recommended) + $0 -s ${DEFAULT_SOURCE} # Install stable release ${DEFAULT_SOURCE#release-}
80-82: Outdated “Available sources” error; generalize and show example.- print_error "Available sources: latest, rc, main, release-0.6" + print_error "Available sources: latest, rc, main, release-<major.minor> (e.g., ${DEFAULT_SOURCE})"
191-193: Prefer custom index as primary to avoid pulling a mismatched build from PyPI.Using --extra-index-url with PyPI as implicit primary may fetch the pinned version from PyPI if present. Make the Jumpstarter index primary and PyPI a fallback.
- if ! python3 -m pip install --extra-index-url "${index_url}" "jumpstarter-all==${version}"; then + if ! python3 -m pip install --index-url "${index_url}" --extra-index-url https://pypi.org/simple "jumpstarter-all==${version}"; then
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
install.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Redirect rules - jumpstarter-docs
- GitHub Check: Header rules - jumpstarter-docs
- GitHub Check: Pages changed - jumpstarter-docs
- GitHub Check: pytest-matrix (macos-15, 3.11)
- GitHub Check: pytest-matrix (macos-15, 3.13)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
- GitHub Check: e2e
- GitHub Check: pytest-matrix (macos-15, 3.12)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
| VENV_DIR="${INSTALL_DIR}/venv" | ||
| SET_SCRIPT="${INSTALL_DIR}/set" | ||
| DEFAULT_SOURCE="release-0.6" | ||
| DEFAULT_SOURCE="release-0.7" |
Contributor
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Bump to release-0.7: LGTM; sync user-facing text.
Change is correct. Please also update help/usage and the invalid-source message that still reference 0.6.
Run to find stale references:
🏁 Script executed:
#!/bin/bash
rg -n --color=never 'release-0\.6|Stable release 0\.6' -g '!**/dist/**' -g '!**/build/**'Length of output: 148
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "PWD: $(pwd)"
echo "--- Top-level files ---"
ls -la | sed -n '1,200p' || true
echo "--- File count (maxdepth 3, excluding .git/dist/build) ---"
find . -maxdepth 3 -type f -not -path "./.git/*" -not -path "./dist/*" -not -path "./build/*" -print | wc -l || true
echo "--- .gitignore (first 200 lines) ---"
if [ -f .gitignore ]; then sed -n '1,200p' .gitignore; else echo "(no .gitignore)"; fi
echo "--- rg version ---"
rg --version || true
echo "--- rg search (no ignore, include hidden) for 'release-0.6' or 'Stable release 0.6' ---"
rg -n --hidden --no-ignore -S -e 'release-0\.6' -e 'Stable release 0\.6' -g '!dist' -g '!build' || true
echo "--- rg search for DEFAULT_SOURCE and 'invalid' / 'usage' / 'help' keywords ---"
rg -n --hidden --no-ignore -S -e 'DEFAULT_SOURCE' -e 'invalid-source' -e 'invalid source' -e '\busage\b' -e '\bhelp\b' -g '!dist' -g '!build' || true
echo "--- Fallback grep (excluding common directories) for '0.6' and related strings ---"
grep -RIn --exclude-dir={dist,build,.git,node_modules} -E 'release-0\.6|Stable release 0\.6|DEFAULT_SOURCE|invalid-source|invalid source|\busage\b|\bhelp\b|0\.6' . || true
echo "--- Locate install.sh (case-insensitive) and print up to 300 lines if found ---"
mapfile -t files < <(find . -type f -iname 'install.sh' -not -path './.git/*' -not -path './dist/*' -not -path './build/*' || true)
if [ "${#files[@]}" -gt 0 ]; then
for f in "${files[@]}"; do
echo "---- $f ----"
sed -n '1,300p' "$f" || true
done
else
echo "(no install.sh found via find). Searching for DEFAULT_SOURCE occurrences instead:"
rg -n --hidden --no-ignore -S 'DEFAULT_SOURCE' -g '!dist' -g '!build' || true
fiLength of output: 61575
Bump to release-0.7 — LGTM; sync user-facing text.
Change is correct. Update remaining help/usage and docs that still reference release-0.6:
- install.sh — lines 42, 44, 52–53, 81: update default/help text and "Available sources" from release-0.6 → release-0.7.
- docs/source/getting-started/installation/packages.md — lines 41–42, 76, 168: update table/examples referencing release-0.6 → release-0.7.
- docs/multiversion.sh — line 4: branch list contains release-0.6 (confirm if it should remain).
- docs/source/getting-started/guides/setup-distributed-mode.md — line 7: mentions "release 0.6.x" (update if meant to refer to 0.7).
🤖 Prompt for AI Agents
In install.sh around line 15 (DEFAULT_SOURCE="release-0.7") and at lines 42, 44,
52–53, and 81, update the default/help text and the "Available sources" entries
that still reference release-0.6 to release-0.7 so help output matches the new
default; also update docs/source/getting-started/installation/packages.md at
lines 41–42, 76, and 168 to replace any examples/tables referencing release-0.6
with release-0.7; check docs/multiversion.sh line 4 and confirm whether
release-0.6 should be removed or retained in the branch list and update
accordingly; and update
docs/source/getting-started/guides/setup-distributed-mode.md line 7 to change
the text "release 0.6.x" to the appropriate "release 0.7.x" (or neutral wording)
so documentation and scripts are consistent.
mangelajo
force-pushed
the
update-installer-branch
branch
from
2943015 to
0ef32cd
Compare
michalskrivanek
approved these changes
Sep 26, 2025
raballew
approved these changes
Sep 26, 2025
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit