This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[Backport release-0.7] client: compare lease selectors#621
Merged
mangelajo merged 1 commit intorelease-0.7from Sep 19, 2025
Merged
[Backport release-0.7] client: compare lease selectors#621mangelajo merged 1 commit intorelease-0.7from
mangelajo merged 1 commit intorelease-0.7from
Conversation
when a lease is already is set in the env (JMP_LEASE), the requested selector will be ignored, even if it does not match the existing lease. Instead of silently using the env lease, warn and create a new lease Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com> (cherry picked from commit b076954)
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
Member
|
Waiting on jumpstarter-dev/jumpstarter#624 to merge so we can backport both at once. |
mangelajo
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-0.7, triggered by a label in #620.