Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[Backport release-0.7] client: compare lease selectors#621

Merged
mangelajo merged 1 commit intorelease-0.7from
backport-620-to-release-0.7
Sep 19, 2025
Merged

[Backport release-0.7] client: compare lease selectors#621
mangelajo merged 1 commit intorelease-0.7from
backport-620-to-release-0.7

Conversation

@jumpstarter-backport-bot
Copy link
Copy Markdown

Bot-based backport to release-0.7, triggered by a label in #620.

when a lease is already is set in the env (JMP_LEASE), the requested selector will be ignored,
even if it does not match the existing lease.

Instead of silently using the env lease, warn and create a new lease

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
(cherry picked from commit b076954)
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 18, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

@mangelajo mangelajo added this to the 0.7.1 milestone Sep 19, 2025
@mangelajo
Copy link
Copy Markdown
Member

Waiting on jumpstarter-dev/jumpstarter#624 to merge so we can backport both at once.

@mangelajo mangelajo enabled auto-merge September 19, 2025 13:19
@mangelajo mangelajo merged commit 182b014 into release-0.7 Sep 19, 2025
14 checks passed
@mangelajo mangelajo deleted the backport-620-to-release-0.7 branch September 19, 2025 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants