This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[Backport release-0.7] Lease handling user enhancements#676
Merged
mangelajo merged 5 commits intorelease-0.7from Oct 1, 2025
Merged
[Backport release-0.7] Lease handling user enhancements#676mangelajo merged 5 commits intorelease-0.7from
mangelajo merged 5 commits intorelease-0.7from
Conversation
When lease is not available we try for 300s to acquire it. Users can also interrupt this with Ctrl+C while waiting. Let's remove such lease requests since after termination the shell is gone and it leaves behind a mostly useless lease. (cherry picked from commit f50c12b)
should also result in immediate error, there's no chance the lease will ever be satisfied (cherry picked from commit 41ee94c)
when trying to acquire a lease it'suseful to know the lease id. Lease changes are not so frequent (and not that fast either), let's poll only once in 5s to save bandwidth a bit (cherry picked from commit cfbe5ff)
it's useful to know where the user is connecting to instead of just "remote". Especially for lease selectors that can be satisfied by multiple exporters. (cherry picked from commit 8256580)
increase the default time we want for lease to become availble to 2h. Add new client config for timeout on lease acquisition: leases: acquisition_timeout: 7200 Also print a clear error message when timeout happens. (cherry picked from commit f20fd63)
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
mangelajo
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-0.7, triggered by a label in #671.