This repository was archived by the owner on Jan 23, 2026. It is now read-only.
feat: probe-rs: added speed configuration option#722
Merged
mangelajo merged 1 commit intojumpstarter-dev:mainfrom Oct 27, 2025
Merged
feat: probe-rs: added speed configuration option#722mangelajo merged 1 commit intojumpstarter-dev:mainfrom
mangelajo merged 1 commit intojumpstarter-dev:mainfrom
Conversation
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
WalkthroughAdded an optional numeric Changes
Sequence Diagram(s)sequenceDiagram
participant Config as Config (YAML)
participant Driver as ProbeRs
participant Env as Environment
Note over Config,Driver: New optional field: speed (kHz)
Config->>Driver: parse probe_rs block (includes speed?)
alt speed present
Driver->>Env: set PROBE_RS_SPEED = "<speed>"
else no speed
Driver-->>Env: no PROBE_RS_SPEED set
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Areas requiring attention:
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/jumpstarter-driver-probe-rs/jumpstarter_driver_probe_rs/driver.py (1)
20-20: LGTM!The field declaration follows the established pattern for optional configuration parameters.
Consider adding validation to ensure speed is positive if set, though this would be consistent with how other fields are currently handled:
def __post_init__(self): if hasattr(super(), "__post_init__"): super().__post_init__() if self.speed is not None and self.speed <= 0: raise ValueError("speed must be positive")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/jumpstarter-driver-probe-rs/README.md(2 hunks)packages/jumpstarter-driver-probe-rs/examples/exporter.yaml(1 hunks)packages/jumpstarter-driver-probe-rs/jumpstarter_driver_probe_rs/driver.py(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
packages/jumpstarter-driver-probe-rs/README.md
39-39: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Redirect rules - jumpstarter-docs
- GitHub Check: Header rules - jumpstarter-docs
- GitHub Check: Pages changed - jumpstarter-docs
- GitHub Check: build
- GitHub Check: e2e
- GitHub Check: pytest-matrix (macos-15, 3.11)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
- GitHub Check: pytest-matrix (macos-15, 3.12)
- GitHub Check: pytest-matrix (macos-15, 3.13)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
- GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
🔇 Additional comments (3)
packages/jumpstarter-driver-probe-rs/examples/exporter.yaml (1)
14-14: LGTM!The speed configuration example is appropriate. The value of 4000 kHz (4 MHz) is a reasonable default for SWD/JTAG communication.
packages/jumpstarter-driver-probe-rs/jumpstarter_driver_probe_rs/driver.py (1)
87-88: LGTM!The environment variable export follows the same pattern as the other configuration parameters and correctly converts the integer value to a string.
packages/jumpstarter-driver-probe-rs/README.md (1)
27-27: LGTM!The example configuration clearly demonstrates the new speed parameter with an appropriate value.
Signed-off-by: Andreas Karner <andreaskarner@outlook.com>
whati001
force-pushed
the
feat/probe_rs_speed
branch
from
874e354 to
b5702fa
Compare
bennyz
approved these changes
Oct 27, 2025
Member
Member
|
Thank you so much for the contribution @whati001 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add speed property to probe-rs driver.
Summary by CodeRabbit
New Features
Documentation