treewide: use fedora 43#166
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThis PR updates Fedora base container image versions from 42 to 43 across Dockerfiles, GitHub Actions workflows, build scripts, and test configurations. Additionally, the curl invocation in the CI workflow includes the --fail flag. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
python/packages/jumpstarter-driver-qemu/jumpstarter_driver_qemu/driver_test.py (1)
100-100: Kernel version assertion is inconsistent with the Fedora 43 image, but proposed fix has incorrect kernel version.The test uses Fedora 43 images (
Fedora-Cloud-Base-Generic-43-1.6.{arch}.qcow2), but the assertion expects Fedora 41 kernel6.11.4-301.fc41.{arch}. The proposed fix suggesting6.12.7-200.fc43is incorrect—Fedora 43 Cloud Base uses the 6.17.x kernel series (stable:6.17.4-300.fc43). Update the assertion to the correct kernel version by booting the image and runninguname -r, or check the Fedora 43 Cloud release notes for the exact kernel version in the specific image build.
🤖 Fix all issues with AI agents
In
`@python/packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh`:
- Around line 6-8: The podman bind-mount uses unquoted $(pwd) which can break on
paths with spaces; update the exec podman run command inside the if block (the
line under if [[ -z "$container" && ! -f /.dockerenv ]]; then) to quote the host
path (e.g., change -v $(pwd):/host:Z to -v "$(pwd)":/host:Z or use "$PWD") so
the mount path is treated as a single argument.
In
`@python/packages/jumpstarter-driver-uboot/jumpstarter_driver_uboot/driver_test.py`:
- Line 18: The test's expected U-Boot version string no longer matches the
U-Boot binary downloaded by url (now pointing to uboot-images-armv8-2025.10...),
so update the assertion that checks the U-Boot version (the expectation around
the string "U-Boot 2024.10 (Oct 11 2024 - 00:00:00 +0000)" in driver_test.py) to
the exact version/build string present in the fc43 2025.10 package; extract the
actual string from the binary in the downloaded RPM and replace the old literal
in the test assertion to avoid the failure.
553df33 to
88df3fd
Compare
|
Thank you for looking at this so quickly @NickCao ! :D |
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.