Skip to content

treewide: use fedora 43#166

Merged
bennyz merged 1 commit intojumpstarter-dev:mainfrom
NickCao:main
Jan 27, 2026
Merged

treewide: use fedora 43#166
bennyz merged 1 commit intojumpstarter-dev:mainfrom
NickCao:main

Conversation

@NickCao
Copy link
Copy Markdown
Contributor

@NickCao NickCao commented Jan 27, 2026

Summary by CodeRabbit

  • Chores

    • Updated container base images from Fedora 42 to Fedora 43 across build scripts and Dockerfiles.
    • Updated Fedora Cloud image versions to 43-1.6 in workflows and test fixtures.
    • Added error handling to container image download operations.
  • Documentation

    • Updated development environment guide to reference Fedora 43.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 27, 2026

Warning

Rate limit exceeded

@NickCao has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

This PR updates Fedora base container image versions from 42 to 43 across Dockerfiles, GitHub Actions workflows, build scripts, and test configurations. Additionally, the curl invocation in the CI workflow includes the --fail flag.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build-oci-bundle.yaml, .github/workflows/python-tests.yaml
Updated Fedora image versions (42→43, and cloud images 41-1.4→43-1.6 with updated URLs); added --fail flag to curl commands in python-tests workflow
Dockerfiles
python/Dockerfile, python/Dockerfile.utils
Updated base image versions from fedora:42 to fedora:43 in builder and product stages
Documentation
python/docs/source/contributing/development-environment.md
Updated Fedora version reference from 42 to 43 in example text
Build Scripts
python/packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh
Updated container image tag from fedora:42 to fedora:43 in podman invocation
Test Configuration
python/packages/jumpstarter-driver-qemu/jumpstarter_driver_qemu/driver_test.py, python/packages/jumpstarter-driver-uboot/jumpstarter_driver_uboot/driver_test.py
Updated Fedora image paths and RPM sources in test fixtures (qemu: 41-1.4→43-1.6; uboot: fc41→fc43)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • mangelajo
  • bennyz

Poem

🐰 wiggles nose From forty-two to forty-three we leap and bound with cheer,
With Fedora's newest base, our builds are bright and clear!
Dockerfiles and workflows dance in perfect sync today,
Tests and scripts all prepped and set, hip-hop-hooray! 🚀✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'treewide: use fedora 43' accurately and concisely summarizes the main change across all modified files—updating Fedora container images from version 42 to 43.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
python/packages/jumpstarter-driver-qemu/jumpstarter_driver_qemu/driver_test.py (1)

100-100: Kernel version assertion is inconsistent with the Fedora 43 image, but proposed fix has incorrect kernel version.

The test uses Fedora 43 images (Fedora-Cloud-Base-Generic-43-1.6.{arch}.qcow2), but the assertion expects Fedora 41 kernel 6.11.4-301.fc41.{arch}. The proposed fix suggesting 6.12.7-200.fc43 is incorrect—Fedora 43 Cloud Base uses the 6.17.x kernel series (stable: 6.17.4-300.fc43). Update the assertion to the correct kernel version by booting the image and running uname -r, or check the Fedora 43 Cloud release notes for the exact kernel version in the specific image build.

🤖 Fix all issues with AI agents
In
`@python/packages/jumpstarter-driver-flashers/oci_bundles/aarch64-itb/build_fits.sh`:
- Around line 6-8: The podman bind-mount uses unquoted $(pwd) which can break on
paths with spaces; update the exec podman run command inside the if block (the
line under if [[ -z "$container" && ! -f /.dockerenv ]]; then) to quote the host
path (e.g., change -v $(pwd):/host:Z to -v "$(pwd)":/host:Z or use "$PWD") so
the mount path is treated as a single argument.

In
`@python/packages/jumpstarter-driver-uboot/jumpstarter_driver_uboot/driver_test.py`:
- Line 18: The test's expected U-Boot version string no longer matches the
U-Boot binary downloaded by url (now pointing to uboot-images-armv8-2025.10...),
so update the assertion that checks the U-Boot version (the expectation around
the string "U-Boot 2024.10 (Oct 11 2024 - 00:00:00 +0000)" in driver_test.py) to
the exact version/build string present in the fc43 2025.10 package; extract the
actual string from the binary in the downloaded RPM and replace the old literal
in the test assertion to avoid the failure.

@NickCao NickCao force-pushed the main branch 6 times, most recently from 553df33 to 88df3fd Compare January 27, 2026 15:38
@bennyz bennyz merged commit 6bc131b into jumpstarter-dev:main Jan 27, 2026
19 checks passed
@mangelajo
Copy link
Copy Markdown
Member

Thank you for looking at this so quickly @NickCao ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants