Fix lease labels over-filtering

[evakhoni]

A quick bug fix for server-side over-filtering where a complex selector was being sent to the server for pre-filtering as-is, instead of sending only its matchLabels subset and handling matchExpressions client-side.

also included some e2e tests to cover that.

this is a follow up PR to #168

Summary by CodeRabbit

• Tests

  • Added end-to-end regression tests covering complex lease selectors: combined label+expression selectors, partial matches, non-matches, and over-filtering scenarios.

• Bug Fixes

  • Listing and deletion of leases with complex selectors now combine server-side label filtering with client-side expression filtering to produce accurate results and avoid unintended over-filtering.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Extracts matchLabels from Kubernetes-style selectors for server-side lease listing, adds client-side post-filtering for matchExpressions in the CLI, and adds e2e tests covering complex selector and over-filtering scenarios.

Changes

Cohort / File(s)	Summary
Selector Utilities python/packages/jumpstarter/jumpstarter/client/selectors.py	Adds `extract_match_labels_filter(selector: str
gRPC Client Integration python/packages/jumpstarter/jumpstarter/client/grpc.py	ListLeases() now calls extract_match_labels_filter() to transform the incoming selector before constructing the gRPC ListLeasesRequest, sending only matchLabels to the server.
CLI Post-filtering python/packages/jumpstarter-cli/jumpstarter_cli/delete.py	When a selector is provided, CLI now applies filter_by_selector(selector) on the returned leases to enforce matchExpressions client-side after server-side matchLabels filtering.
End-to-End Tests e2e/tests.bats	Adds regression tests validating combined matchLabels + matchExpressions selectors, partial matches, non-matches, and over-filtering behavior; retains existing lease creation and cleanup flow.

Sequence Diagram(s)

sequenceDiagram
    participant CLI as CLI
    participant Client as Client\n(grpc.py)
    participant Selector as Selector\n(selectors.py)
    participant Server as gRPC Server
    participant DB as Lease Store

    CLI->>Client: list_leases(selector)
    Client->>Selector: extract_match_labels_filter(selector)
    Selector-->>Client: matchLabelsFilter (e.g. "k=v,a=b") or null
    Client->>Server: ListLeasesRequest(filter=matchLabelsFilter)
    Server->>DB: query leases by metadata labels
    DB-->>Server: leases (may include items matching matchExpressions)
    Server-->>Client: ListLeasesResponse(leases)
    Client->>Client: if selector contains matchExpressions\napply client-side filter_by_selector(selector)
    Client-->>CLI: filtered leases

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Cross-namespace listen queue collision due to bare leaseName key #353 — Related changes to how selector strings are handled and passed for lease filtering (server vs client-side handling).
• cli: add lease transfer option #338 — Modifications to lease selector parsing and list/filter behavior; overlaps selector handling logic.
• allow lease filtering by exporter labels #168 — Server-side adjustments to lease label handling that complement client-side extraction of matchLabels.

Suggested reviewers

• bkhizgiy
• bennyz
• mangelajo

Poem

🐰 I nibble selectors, pluck labels with delight,
I send matchLabels forward, keep expressions in sight,
If expressions remain, I filter once more,
Leases fall in line — hop, hop, encore! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: fixing server-side over-filtering of lease labels by separating matchLabels and matchExpressions handling.
Docstring Coverage	✅ Passed	Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@python/packages/jumpstarter/jumpstarter/client/grpc.py`:
- Line 386: The gRPC call in list_leases strips matchExpressions via
extract_match_labels_filter, so callers that pass a full selector must perform
client-side filtering; update the delete command implementation
(jumpstarter_cli/delete.py inside the delete logic that currently calls
config.list_leases(filter=selector)) to call .filter_by_selector(selector) on
the returned list of leases (or explicitly document why matchExpressions are
irrelevant), ensuring only leases that satisfy the full selector (including
matchExpressions) are processed; reference extract_match_labels_filter,
list_leases, and filter_by_selector when locating the change.

[evakhoni]

hmm.. e2e caught something.. back to draft and investigating.

[evakhoni]

ok found the issue, it was the test not the feature. should be good now. let's see the CI 🤞