fix(shell): block dangerous environment variables#429
Merged
Conversation
Add a blocklist of security-sensitive environment variables (LD_PRELOAD, PATH, PYTHONPATH, etc.) and dangerous prefixes (LD_*, BASH_FUNC_*) to prevent privilege escalation through the shell driver's env var passthrough. Fixes #359 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
PR Review StatusCI Status: All checks are passing (build, pytest, e2e tests, lint, typos). Review Comments: No unaddressed review comments found. Code Review Notes:
No code changes needed at this time. The PR looks ready for maintainer review. 🤖 Generated with Claude Code |
mangelajo
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LD_PRELOAD,LD_LIBRARY_PATH,PATH,PYTHONPATH,BASH_ENV,KUBECONFIG,HOME) and dangerous prefixes (LD_*,BASH_FUNC_*) to the shell driver's_validate_script_paramsmethodFixes #359
Test plan
make lint-fix🤖 Generated with Claude Code