Conversation
The test_passthrough_to_public_api test was flaky because it depended on the external httpbin.org service, which intermittently returns 502 errors. Replace it with a local HTTP server to eliminate the external dependency while still validating the proxy passthrough behavior. Fixes #626 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mangelajo
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_passthrough_to_public_apitest that intermittently failed with a 502 response because it depended on the externalhttpbin.orgservicehttp.server-based server started within the test, eliminating network-related flakiness entirely_can_reach_internet()helper and skip conditionFixes #626
Test plan
make lint-fixpassesmake pkg-test-jumpstarter-driver-mitmproxypasses (101 tests)🤖 Generated with Claude Code