Output console messages directly with :Vader! - improve Neovim support#175
Merged
blueyed merged 9 commits intojunegunn:masterfrom Nov 21, 2018
Merged
Output console messages directly with :Vader! - improve Neovim support#175blueyed merged 9 commits intojunegunn:masterfrom
blueyed merged 9 commits intojunegunn:masterfrom
Conversation
blueyed
commented
Aug 10, 2018
| endfunction | ||
| endif | ||
| endif | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
@justinmk
Does this make sense? (came up with this via neovim/neovim#8846)
There was a problem hiding this comment.
yes but I wouldn't bother supporting older nvim versions without v:stderr (and you only need to check exists('v:stderr').
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
- Coverage 86.99% 86.51% -0.49%
==========================================
Files 12 12
Lines 746 771 +25
==========================================
+ Hits 649 667 +18
- Misses 97 104 +7
Continue to review full report at Codecov.
|
blueyed
changed the title
blueyed
force-pushed
the
echo
branch
5 times, most recently
from
cfe6fe5 to
78a9065
Compare
blueyed
added a commit
to neomake/neomake
that referenced
this pull request
Aug 13, 2018
Also skips logging output from NVIM_LOG_FILE, :echom etc. This is needed with junegunn/vader.vim#175, where those will come after "Starting Vader" now. [ci skip]
okhin
pushed a commit
to okhin/neomake
that referenced
this pull request
Sep 11, 2018
Also skips logging output from NVIM_LOG_FILE, :echom etc. This is needed with junegunn/vader.vim#175, where those will come after "Starting Vader" now. [ci skip]
This will write console output directly, instead of buffering it.
This is relevant with $VADER_ECHO_MESSAGES, and not using $VADER_OUTPUT_FILE.
- VADER_ECHO_MESSAGES can be stderr/stdout (defaults to stderr, if non-empty) - Detects if `nvim --headless` is used, where `:echon` can be used
No need to have VADER_ECHO_MESSAGES, but just skip s:console_buffer with `:Vader!` in general. Also improves `vader#print_stderr` to support Neovim directly (without VADER_OUTPUT_FILE).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skips the console buffer for
:Vader!, but echos messages directly to stderr.Writing to stderr is improved for Neovim (v0.3.0+), which should make this work on Windows by default.
My main motivation here was to make this work on Windows with Neovim, but then also noticed that it is really good to have the output as it comes already.
TODO:
Includes #177.