Fix breakage to 'PlugUpgrade' under Windows PowerShell.#1331
Merged
Conversation
Commit 09b7c0e has caused this command to emit an error during its cleanup when run on Windows with 'shell' set to PowerShell. The cause of the failure is that the cleanup logic passes the command string 'rmdir /s /q' to `s:system()` (within `s:rm_rf()`). Before the commit at fault, this command would be written to a batch file and executed by 'cmd.exe'. After the commit, it is passed directly to PowerShell for execution, where 'rmdir' is an alias for 'Remove-Item' and does not support '/s' and '/q' flags.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 09b7c0e has caused this command to emit an error during its cleanup when run on Windows with 'shell' set to PowerShell.
The cause of the failure is that the cleanup logic passes the command string 'rmdir /s /q' to
s:system()(withins:rm_rf()). Before the commit at fault, this command would be written to a batch file and executed by 'cmd.exe'. After the commit, it is passed directly to PowerShell for execution, where 'rmdir' is an alias for 'Remove-Item' and does not support '/s' and '/q' flags.Describe the details of your PR ...