Skip to content

Conversation

@halitanildonmez
Copy link
Contributor

Overview

Hello! This commit solves the linked issue. Though here are some things that I wanted to point out.

I had to point to the fonts directory at the documentation.gradle.kts file because I was getting errors saying that
GEM_FONTS_DIR was not found.

After update, I had to download the default fonts from https://github.com/asciidoctor/asciidoctor-pdf/tree/master/data/fonts

I also changed the "rare" Japanese charset, U+FF0 emoji.

Here: https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.5.x/docs/theming-guide.adoc#applying-your-theme it says that one can do pdf-fontsdir="path/to/fonts;GEM_FONTS_DIR" yet it did not worked.

Yet this commit solves the emoji problem.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp linked an issue Jul 31, 2020 that may be closed by this pull request
1 task
@marcphilipp
Copy link
Member

Thanks! I'd like to avoid copying the fonts. Let's see if we can get @mojavelinux to chime in on #2315 (comment). 🙇‍♂️

@mojavelinux
Copy link
Contributor

You definitely should not have to copy the fonts. I'll have a look and see if I can detect what is going wrong.

@halitanildonmez
Copy link
Contributor Author

I left a comment at #2315 (comment) and the issue should be fixed now but thank you @marcphilipp and @mojavelinux again for the help 😄

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #2367 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2367      +/-   ##
============================================
- Coverage     89.90%   89.88%   -0.03%     
  Complexity     4545     4545              
============================================
  Files           396      396              
  Lines         11198    11198              
  Branches        908      908              
============================================
- Hits          10068    10065       -3     
  Misses          856      856              
- Partials        274      277       +3     
Impacted Files Coverage Δ Complexity Δ
...t/vintage/engine/execution/RunListenerAdapter.java 91.83% <0.00%> (-2.05%) 43.00% <0.00%> (-2.00%)
...va/org/junit/vintage/engine/execution/TestRun.java 93.26% <0.00%> (-0.97%) 29.00% <0.00%> (-1.00%)
...rc/main/kotlin/org/junit/jupiter/api/Assertions.kt 62.96% <0.00%> (ø) 3.00% <0.00%> (+3.00%)
...main/java/org/junit/jupiter/api/MethodOrderer.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
...va/org/junit/jupiter/api/DisplayNameGenerator.java 75.36% <0.00%> (ø) 2.00% <0.00%> (ø%)
...va/org/junit/jupiter/params/provider/NullEnum.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...a/org/junit/jupiter/params/provider/Arguments.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
.../junit/jupiter/api/extension/ExtensionContext.java 92.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
...g/junit/platform/testkit/engine/EngineTestKit.java 75.34% <0.00%> (ø) 17.00% <0.00%> (ø%)
...g/junit/platform/launcher/core/LauncherConfig.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d19a4...b6dfab4. Read the comment docs.

Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #2315 (comment)

Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there... 🙂

@marcphilipp marcphilipp changed the title Issues/2315 pdf support special characters Fix special characters in PDF version of User Guide Aug 2, 2020
@marcphilipp marcphilipp merged commit b0645bc into junit-team:main Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Guide PDF should support special characters

3 participants