-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix special characters in PDF version of User Guide #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix special characters in PDF version of User Guide #2367
Conversation
…ve the fonts and theme to resources, do not use the rare emoji
|
Thanks! I'd like to avoid copying the fonts. Let's see if we can get @mojavelinux to chime in on #2315 (comment). 🙇♂️ |
|
You definitely should not have to copy the fonts. I'll have a look and see if I can detect what is going wrong. |
…adoc instead of gradle build file
|
I left a comment at #2315 (comment) and the issue should be fixed now but thank you @marcphilipp and @mojavelinux again for the help 😄 |
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
============================================
- Coverage 89.90% 89.88% -0.03%
Complexity 4545 4545
============================================
Files 396 396
Lines 11198 11198
Branches 908 908
============================================
- Hits 10068 10065 -3
Misses 856 856
- Partials 274 277 +3 Continue to review full report at Codecov.
|
marcphilipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #2315 (comment)
marcphilipp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there... 🙂
Overview
Hello! This commit solves the linked issue. Though here are some things that I wanted to point out.
I had to point to the fonts directory at the
documentation.gradle.ktsfile because I was getting errors saying thatGEM_FONTS_DIR was not found.
After update, I had to download the default fonts from https://github.com/asciidoctor/asciidoctor-pdf/tree/master/data/fonts
I also changed the "rare" Japanese charset, U+FF0 emoji.
Here: https://github.com/asciidoctor/asciidoctor-pdf/blob/v1.5.x/docs/theming-guide.adoc#applying-your-theme it says that one can do
pdf-fontsdir="path/to/fonts;GEM_FONTS_DIR"yet it did not worked.Yet this commit solves the emoji problem.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations