Skip to content

Conversation

@marcphilipp
Copy link
Member

Overview

Resolves #4130.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp self-assigned this Jan 25, 2025
@marcphilipp marcphilipp force-pushed the marc/4130-display-name-generator-runtime-enclosing-types branch from 4d62a3d to 90f96dc Compare January 25, 2025 13:03
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @marcphilipp.

I reviewed the PR in the browser and made some suggestions for minor improvements regarding Javadoc.

Regarding the implementation, that also looks good (at least as far as I can tell within the browser), and the new tests reflect what I'd expect. 👍

marcphilipp and others added 2 commits January 25, 2025 18:08
Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
@marcphilipp marcphilipp requested a review from sbrannen January 25, 2025 17:36
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the previous changes!

I've requested two minor Javadoc changes.

Co-authored-by: Sam Brannen <104798+sbrannen@users.noreply.github.com>
@marcphilipp marcphilipp merged commit 060f4db into main Jan 26, 2025
15 checks passed
@marcphilipp marcphilipp deleted the marc/4130-display-name-generator-runtime-enclosing-types branch January 26, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DisplayNameGenerator cannot access runtime enclosing type for @Nested test class

3 participants