Skip to content

Conversation

@jodastephen
Copy link
Contributor

@jodastephen jodastephen commented Nov 30, 2025

This extends the fallback String to Object converter algorithm to exclude deprecated methods. This occurs after the existing algorithm finished. As such, any code that works today will continue to work. It is possible that this PR will make some code that fails today start to work, but that seems to be an acceptable outcome.

Release notes will need adding.

Fixes #4996


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Extends the algorithm to exclude deprecated methods.
This extension occurs after the existing logic completes.
Fixes junit-team#4996
@sbrannen sbrannen changed the title Extend fallback String-Object converter Exclude competing @Deprecated factory methods in fallback String-to-Object converter Dec 1, 2025
Copilot AI review requested due to automatic review settings December 10, 2025 15:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Dec 10, 2025

@jodastephen could you satisfy the DCO bot?

Oh and please ignore co-pilot. I'm not sure where that came from, but it is not something from the JUnit team. 🤔

@testlens-app
Copy link

testlens-app bot commented Dec 10, 2025

✅ All tests passed ✅

⚠️ TestLens detected flakiness ⚠️

Test Summary

Check Task Test Runs
CI / macOS :jupiter-tests:test SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded ⚠️

🏷️ Commit: 417f9a1
▶️ Tests: 59172 executed
⚪️ Checks: 14/14 completed

Test Failures

SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in macOS)
java.lang.AssertionError: 
Expecting code to raise a throwable.
	at org.junit.jupiter.engine.extension.SeparateThreadTimeoutInvocationTests.throwsTimeoutException(SeparateThreadTimeoutInvocationTests.java:50)
SeparateThreadTimeoutInvocation > throws timeout exception when timeout duration is exceeded (:jupiter-tests:test in macOS)
java.lang.AssertionError: 
Expecting code to raise a throwable.
	at org.junit.jupiter.engine.extension.SeparateThreadTimeoutInvocationTests.throwsTimeoutException(SeparateThreadTimeoutInvocationTests.java:50)

Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implicit conversion should avoid @Deprecated methods

2 participants