Skip to content

Add reference to docker extension#595

Closed
FaustXVI wants to merge 1 commit into
junit-team:masterfrom
FaustXVI:add-junit5-docker-extension
Closed

Add reference to docker extension#595
FaustXVI wants to merge 1 commit into
junit-team:masterfrom
FaustXVI:add-junit5-docker-extension

Conversation

@FaustXVI
Copy link
Copy Markdown

@FaustXVI FaustXVI commented Dec 8, 2016

Overview

Add a link to an extension that allow the user to start docker containers from their tests.

JUnit5-Docker has just been pushed to maven contral as a release candidate for version 1.0.0.
It only implements one feature : start one container from your test. The idea is to have something that works early. More features to come.

I think it will be a very useful extension and adding the reference to the documentation would show that an extension can do something else than integrate with another framework.


I hereby agree to the terms of the JUnit Contributor License Agreement.

@jbduncan
Copy link
Copy Markdown
Contributor

jbduncan commented Dec 8, 2016

Have you considered making your proposal on junit-io? :)

@nipafx
Copy link
Copy Markdown

nipafx commented Dec 8, 2016

@FaustXVI The Docker extension looks pretty cool, great idea!

I started JUnit Io to collect small(ish) extensions and breed ideas but didn't get very far yet. Your extension seems to be pretty well-defined and self-contained, so it makes sense to be its own library. But if you see value in merging into another project, I'm happy to discuss that.

@FaustXVI
Copy link
Copy Markdown
Author

FaustXVI commented Dec 8, 2016

@nicolaiparlog That's a great initiative !
For the moment, I do agree that, since we have a quite well-defined scope it totally make sens to keep it separated.
Nonetheless, I keep the idea in mind, maybe I'll change my mind someday :)

@smoyer64
Copy link
Copy Markdown
Contributor

smoyer64 commented Dec 8, 2016

@FaustXVI

This seems like one of those situations where @BeforeSuite/@AfterSuite would be ideal when you want the container to be used for more than one class. In any case, it looks awesome. Looking at your commits, I see that you're adding the reference to the users guide ... there's an open issue with the subject "Maintain list of third-party TestEngines and Extensions" #297 that you might want to look at.

@FaustXVI
Copy link
Copy Markdown
Author

FaustXVI commented Dec 8, 2016

Using @BeforeSuite and @AfterSuite is great idea ! I'll add it to my issues.
I'll definitely look at #297 , thanks !

@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Dec 9, 2016

closing this issue since it will be addressed in #297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants