Fix bug on JDK 9 #1507
Merged
Fix bug on JDK 9 #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbirkner
force-pushed
the
jdk9
branch
3 times, most recently
from
601d6e2 to
7f66629
Compare
panchenko
reviewed
Feb 20, 2018
| //Java < 9: | ||
| equalTo(asList("methodA", "methodB", "methodC")), | ||
| //Java >= 9 has annotations on methods of java.lang.Object: | ||
| equalTo(asList("clone", "finalize", "getClass", "hashCode", |
Contributor
There was a problem hiding this comment.
I would suggest ignoring the jdk.internal.* annotations completely.
Contributor
Author
There was a problem hiding this comment.
Although I understand your motivation I would like to keep it like it is, because the implemented method does nothing wrong. The test has a wrong assumption about the class. IMHO the problem here is that the test is not good enough. I write a better test.
Member
There was a problem hiding this comment.
I agree with Alex. The tests would be less.fragile if you filtered out the jdk.internal.* annotations. They are, after all, internal.
Contributor
Author
There was a problem hiding this comment.
I rewrote the tests so that they are less fragile. Therefore I don't have to change getAnnotatedMethods by adding a filter.
JDK 9 uses classes from the package jdk.internal.reflect instead of sun.reflect.
Use same coding style within TestClassTest.
Make the test less fragile. The number of annotated methods varies because Java 9 introduces new annotations for some methods of Object.
Make the test providesAnnotatedMethodsSortedByName less fragile. (Before the test failed on JDK 9 because Java 9 introduces new annotations for some methods of Object.)
Developers with a current JDK 9 on their machines are currently not able to easily build JUnit. This commit makes it possible to develop with JDK 9 and ensures that JUnit can be build with JDK 0.
marcphilipp
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.