chore: bump keychain to 1.1#17
Merged
AaronCQL merged 4 commits intojup-ag:mainfrom Apr 26, 2026
Merged
Conversation
Leverage unified `createKeychainSigner` factory function and unified helpers/types (e.g. `BackendName`, `KeychainSignerConfig`, `resolveAddress`)
Keep persisted shape as { backend, address, params } and translate to
KeychainSignerConfig at the boundary via KeychainConfig.toSignerConfig().
Avoids breaking existing keychain-backed keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AaronCQL based on the previous PR we made some tweaks to Keychain to improve package size:
Bumps
@solana/keychainfrom^0.6.1to^1.1.0and refactors our keychain integration to use the newcreateKeychainSigner/resolveAddress/KeychainSignerConfigprimitives.Bundle size impact
Most of the reduction comes from upstream work in the keychain package ‚ notably replacing
@google-cloud/kms(which drags in grpc/protobuf) with direct REST calls viagoogle-auth-library.Code changes
src/lib/KeychainConfig.ts: utilize helpers from @solana/keychainsrc/commands/KeysCommand.ts:addKeychainnow usesresolveAddress()from@solana/keychaininstead of creating a full signer to get the address. Validation delegates to the typedKeychainSignerConfigdiscriminated union.src/lib/Signer.ts: CallscreateKeychainSigner()directly instead of our custom dispatch.Test plan
bun run cipasses (fmt, lint, typecheck, 66 tests)bun run buildproduces a working bundle